Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2743123002: ICU data customization for iOS (Closed)

Created:
3 years, 9 months ago by jungshik at Google
Modified:
3 years, 7 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, michaeldo
Target Ref:
refs/heads/master
Project:
icu
Visibility:
Public.

Description

Customize the ICU data for iOS Add ios/icudtl.dat and ios/patch_locale.sh. Update README.chromium and BUILD.gn accordingly. Update scripts/copy_data.sh to take (ios|common|android). At the moment, iOS data is almost identical to that of Android, but in the future more cuts may be made (e.g. dictionary data for breakiterator). Bug: 718955 TEST: iOS Chrome works as before. Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4b06aadd0556135d3a90a4eb03eca24ef249e03e

Patch Set 1 #

Patch Set 2 : update ios ICU data #

Patch Set 3 : update script #

Patch Set 4 : script update #

Patch Set 5 : update BUILD.gn and icudtl.dat for iOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -12 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M README.chromium View 1 2 3 4 2 chunks +16 lines, -3 lines 0 comments Download
A ios/icudtl.dat View 1 2 3 4 Binary file 0 comments Download
A ios/patch_locale.sh View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M scripts/copy_data.sh View 1 2 1 chunk +39 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jungshik at Google
3 years, 9 months ago (2017-03-10 22:31:29 UTC) #1
michaeldo
jshin@ Is there anything else needed before we can land this change?
3 years, 8 months ago (2017-04-13 19:33:16 UTC) #3
jungshik at Google
Hi Mike, I moved it to https://chromium-review.googlesource.com/c/497829/ That way, you can cherry-pick a CL including ...
3 years, 7 months ago (2017-05-05 18:02:53 UTC) #5
jungshik at Google
3 years, 7 months ago (2017-05-05 21:40:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
4b06aadd0556135d3a90a4eb03eca24ef249e03e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698