Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5620)

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2743063004: MD Settings: use the subLabel of <settings-toggle-button>s for the aria (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_toggle_button.html
diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.html b/chrome/browser/resources/settings/controls/settings_toggle_button.html
index 160efc67dae02978a9044ddb9e860082f22d8979..78bc22a4132960e7246471bfa852eab214afc863 100644
--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html
+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html
@@ -39,7 +39,7 @@
actionable$="[[!controlDisabled_(disabled, pref.*)]]"
hidden="[[!label]]">
<div id="label" class="label">[[label]]</div>
- <div class="secondary label">[[subLabel]]</div>
+ <div id="subLabel" class="secondary label">[[subLabel]]</div>
</div>
<content select=".more-actions"></content>
<template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]">
@@ -48,6 +48,7 @@
</template>
<paper-toggle-button id="control" checked="{{checked}}"
on-change="notifyChangedByUserInteraction" aria-labelledby="label"
+ aria-describedby="subLabel"
disabled="[[controlDisabled_(disabled, pref)]]">
</paper-toggle-button>
</div>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698