third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2743053003: [Reland #1] Don't create layout objects for children of display-none iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2743053003: [Reland #1] Don't create layout objects for children of display-none iframes. (Closed)

Patch Set: rebaseline. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 4b1eee0cf97db208f08a736174f0fb57443a3028..a56d50c246e4ee37823dbcc1753d3095ba306f65 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1658,8 +1658,8 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(

ownerElement->browsingContextContainerName(),

ownerElement->scrollingMode(), ownerElement->marginWidth(),

ownerElement->marginHeight(), ownerElement->allowFullscreen(),

- ownerElement->allowPaymentRequest(), ownerElement->csp(),

- ownerElement->allowedFeatures());

+ ownerElement->allowPaymentRequest(), ownerElement->isDisplayNone(),

+ ownerElement->csp(), ownerElement->allowedFeatures());

// FIXME: Using subResourceAttributeName as fallback is not a perfect

// solution. subResourceAttributeName returns just one attribute name. The

// element might not have the attribute, and there might be other attributes