Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2743053003: [Reland #1] Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Fix DOM object leaks. Diff this against Patch Set 10. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 7a7841640270a41d56da11201296ccc46917fdb7..cbfe093f8fcac33ff379c680efaf6c176935d267 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1637,8 +1637,9 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(
ownerElement->browsingContextContainerName(),
ownerElement->scrollingMode(), ownerElement->marginWidth(),
ownerElement->marginHeight(), ownerElement->allowFullscreen(),
- ownerElement->allowPaymentRequest(), ownerElement->csp(),
- ownerElement->delegatedPermissions(), ownerElement->allowedFeatures());
+ ownerElement->allowPaymentRequest(), ownerElement->isDisplayNone(),
+ ownerElement->csp(), ownerElement->delegatedPermissions(),
+ ownerElement->allowedFeatures());
// FIXME: Using subResourceAttributeName as fallback is not a perfect
// solution. subResourceAttributeName returns just one attribute name. The
// element might not have the attribute, and there might be other attributes

Powered by Google App Engine
This is Rietveld 408576698