Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2743053003: [Reland #1] Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Fix DOM object leaks. Diff this against Patch Set 10. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
index bae944f4642d6ab65773a301c6107f60aed527fb..4eebec4b9028f3ff368e90d4d6a6f5569dc61835 100644
--- a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
+++ b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
@@ -918,7 +918,7 @@ void LocalFrameClientImpl::didAddContentSecurityPolicy(
}
void LocalFrameClientImpl::didChangeFrameOwnerProperties(
- HTMLFrameElementBase* frameElement) {
+ HTMLFrameOwnerElement* frameElement) {
if (!m_webFrame->client())
return;
@@ -928,8 +928,8 @@ void LocalFrameClientImpl::didChangeFrameOwnerProperties(
frameElement->browsingContextContainerName(),
frameElement->scrollingMode(), frameElement->marginWidth(),
frameElement->marginHeight(), frameElement->allowFullscreen(),
- frameElement->allowPaymentRequest(), frameElement->csp(),
- frameElement->delegatedPermissions(),
+ frameElement->allowPaymentRequest(), frameElement->isDisplayNone(),
+ frameElement->csp(), frameElement->delegatedPermissions(),
frameElement->allowedFeatures()));
}

Powered by Google App Engine
This is Rietveld 408576698