Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameOwner.h

Issue 2743053003: [Reland #1] Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: rebaseline. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef FrameOwner_h 5 #ifndef FrameOwner_h
6 #define FrameOwner_h 6 #define FrameOwner_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/dom/SandboxFlags.h" 9 #include "core/dom/SandboxFlags.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
(...skipping 30 matching lines...) Expand all
41 41
42 // Returns the 'name' content attribute value of the browsing context 42 // Returns the 'name' content attribute value of the browsing context
43 // container. 43 // container.
44 // https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-conta iner 44 // https://html.spec.whatwg.org/multipage/browsers.html#browsing-context-conta iner
45 virtual AtomicString browsingContextContainerName() const = 0; 45 virtual AtomicString browsingContextContainerName() const = 0;
46 virtual ScrollbarMode scrollingMode() const = 0; 46 virtual ScrollbarMode scrollingMode() const = 0;
47 virtual int marginWidth() const = 0; 47 virtual int marginWidth() const = 0;
48 virtual int marginHeight() const = 0; 48 virtual int marginHeight() const = 0;
49 virtual bool allowFullscreen() const = 0; 49 virtual bool allowFullscreen() const = 0;
50 virtual bool allowPaymentRequest() const = 0; 50 virtual bool allowPaymentRequest() const = 0;
51 virtual bool isDisplayNone() const = 0;
51 virtual AtomicString csp() const = 0; 52 virtual AtomicString csp() const = 0;
52 virtual const WebVector<WebFeaturePolicyFeature>& allowedFeatures() const = 0; 53 virtual const WebVector<WebFeaturePolicyFeature>& allowedFeatures() const = 0;
53 }; 54 };
54 55
55 // TODO(dcheng): This class is an internal implementation detail of provisional 56 // TODO(dcheng): This class is an internal implementation detail of provisional
56 // frames. Move this into WebLocalFrameImpl.cpp and remove existing dependencies 57 // frames. Move this into WebLocalFrameImpl.cpp and remove existing dependencies
57 // on it. 58 // on it.
58 class CORE_EXPORT DummyFrameOwner 59 class CORE_EXPORT DummyFrameOwner
59 : public GarbageCollectedFinalized<DummyFrameOwner>, 60 : public GarbageCollectedFinalized<DummyFrameOwner>,
60 public FrameOwner { 61 public FrameOwner {
(...skipping 13 matching lines...) Expand all
74 bool canRenderFallbackContent() const override { return false; } 75 bool canRenderFallbackContent() const override { return false; }
75 void renderFallbackContent() override {} 76 void renderFallbackContent() override {}
76 AtomicString browsingContextContainerName() const override { 77 AtomicString browsingContextContainerName() const override {
77 return AtomicString(); 78 return AtomicString();
78 } 79 }
79 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; } 80 ScrollbarMode scrollingMode() const override { return ScrollbarAuto; }
80 int marginWidth() const override { return -1; } 81 int marginWidth() const override { return -1; }
81 int marginHeight() const override { return -1; } 82 int marginHeight() const override { return -1; }
82 bool allowFullscreen() const override { return false; } 83 bool allowFullscreen() const override { return false; }
83 bool allowPaymentRequest() const override { return false; } 84 bool allowPaymentRequest() const override { return false; }
85 bool isDisplayNone() const override { return false; }
84 AtomicString csp() const override { return nullAtom; } 86 AtomicString csp() const override { return nullAtom; }
85 const WebVector<WebFeaturePolicyFeature>& allowedFeatures() const override { 87 const WebVector<WebFeaturePolicyFeature>& allowedFeatures() const override {
86 DEFINE_STATIC_LOCAL(WebVector<WebFeaturePolicyFeature>, features, ()); 88 DEFINE_STATIC_LOCAL(WebVector<WebFeaturePolicyFeature>, features, ());
87 return features; 89 return features;
88 } 90 }
89 91
90 private: 92 private:
91 // Intentionally private to prevent redundant checks when the type is 93 // Intentionally private to prevent redundant checks when the type is
92 // already DummyFrameOwner. 94 // already DummyFrameOwner.
93 bool isLocal() const override { return false; } 95 bool isLocal() const override { return false; }
94 bool isRemote() const override { return false; } 96 bool isRemote() const override { return false; }
95 }; 97 };
96 98
97 } // namespace blink 99 } // namespace blink
98 100
99 #endif // FrameOwner_h 101 #endif // FrameOwner_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698