Add webdriver endpoint to send custom debugger commands

chrome/test/chromedriver/base_logger.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/test/chromedriver/base_logger.h"
+
+#include <string>
+
+#include "base/json/json_writer.h"
+#include "base/values.h"
+#include "chrome/test/chromedriver/chrome/log.h"
+
+BaseLogger::BaseLogger(Log* log)
+    : log_(log) {}
+
+void BaseLogger::AddLogEntry(

[samuong, 2017/03/27 18:42:10]

I'm not sure this should be a separate base class. The
webview/message.method/message.params structure might not apply to the
DevToolsEventsLogger (and the TODO comment definitely doesn't apply) and it
complicates the inheritance hierarchy.

Why not just call log_->AddEntry directly in DevToolsEventsLogger::OnEvent?

+    Log::Level level,
+    const std::string& webview,
+    const std::string& method,
+    const base::DictionaryValue& params) {
+  base::DictionaryValue log_message_dict;
+  log_message_dict.SetString("webview", webview);
+  log_message_dict.SetString("message.method", method);
+  log_message_dict.Set("message.params", params.DeepCopy());
+  std::string log_message_json;
+  base::JSONWriter::Write(log_message_dict, &log_message_json);
+
+  // TODO(klm): extract timestamp from params?
+  // Look at where it is for Page, Network, Timeline, and trace events.
+  log_->AddEntry(level, log_message_json);
+}
+
+void BaseLogger::AddLogEntry(
+    const std::string& webview,
+    const std::string& method,
+    const base::DictionaryValue& params) {
+  AddLogEntry(Log::kInfo, webview, method, params);
+}