Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: ios/web/public/navigation_manager.h

Issue 2742953003: created web::ReloadType (Closed)
Patch Set: Add TODO for ORIGINAL_REQUEST_URL Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/navigation_manager.h
diff --git a/ios/web/public/navigation_manager.h b/ios/web/public/navigation_manager.h
index 3cd75e3613e268ed9c5396ae3eb51473a30cde7d..a13a64ade00448e6895bec787e5bc58a1c6c0cb8 100644
--- a/ios/web/public/navigation_manager.h
+++ b/ios/web/public/navigation_manager.h
@@ -10,6 +10,7 @@
#import "base/mac/scoped_nsobject.h"
#include "ios/web/public/browser_url_rewriter.h"
#include "ios/web/public/referrer.h"
+#include "ios/web/public/reload_type.h"
#include "ui/base/page_transition_types.h"
@class NSDictionary;
@@ -149,11 +150,14 @@ class NavigationManager {
// TODO(crbug.com/533848): Update to use size_t.
virtual void GoToIndex(int index) = 0;
- // Reloads the current item. If |check_for_repost| is true and the current
- // item has POST data the user is prompted to see if they really want to
- // reload the page. In nearly all cases pass in true. If a transient item is
- // showing, initiates a new navigation to its URL.
- virtual void Reload(bool check_for_repost) = 0;
+ // Reloads the visible item under the specified ReloadType. If
+ // |check_for_repost| is true and the current item has POST data the user is
+ // prompted to see if they really want to reload the page. In nearly all cases
+ // pass in true. If a transient item is showing, initiates a new navigation
+ // to its URL.
+ // TODO(crbug.com/700571): implement the logic for when |reload_type| is
+ // ORIGINAL_REQUEST_URL.
Eugene But (OOO till 7-30) 2017/03/11 00:33:36 Since you touching this, could you please add a bu
liaoyuke 2017/03/13 16:40:06 Done.
+ virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;
// Forces the pending item to be loaded using desktop user agent. Note that
// the pending item may or may not already exist.

Powered by Google App Engine
This is Rietveld 408576698