created web::ReloadType

ios/web/public/navigation_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_
 #define IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_
 
 #include <stddef.h>
 
 #import "base/mac/scoped_nsobject.h"
 #include "ios/web/public/browser_url_rewriter.h"
 #include "ios/web/public/referrer.h"
 #include "ui/base/page_transition_types.h"
 
 @class NSDictionary;
 @class NSData;
 
 namespace web {
 
 class BrowserState;
 class NavigationItem;
 class WebState;
+enum class ReloadType : short;

[kkhorimoto, 2017/03/10 21:26:45]

same comment about includes

[liaoyuke, 2017/03/10 21:42:35]

Done.

 
 // A NavigationManager maintains the back-forward list for a WebState and
 // manages all navigation within that list.
 //
 // Each NavigationManager belongs to one WebState; each WebState has
 // exactly one NavigationManager.
 class NavigationManager {
  public:
   // Parameters for URL loading. Most parameters are optional, and can be left
   // at the default values set by the constructor.
@@ skipping 109 matching lines @@
   virtual bool CanGoBack() const = 0;
   virtual bool CanGoForward() const = 0;
   virtual bool CanGoToOffset(int offset) const = 0;
   virtual void GoBack() = 0;
   virtual void GoForward() = 0;
 
   // Navigates to the specified absolute index.
   // TODO(crbug.com/533848): Update to use size_t.
   virtual void GoToIndex(int index) = 0;
 
-  // Reloads the current item. If |check_for_repost| is true and the current
-  // item has POST data the user is prompted to see if they really want to
-  // reload the page. In nearly all cases pass in true.  If a transient item is
-  // showing, initiates a new navigation to its URL.
-  virtual void Reload(bool check_for_repost) = 0;
+  // Reloads the visible item under the specified ReloadType. If
+  // |check_for_repost| is true and the current item has POST data the user is
+  // prompted to see if they really want to reload the page. In nearly all cases
+  // pass in true.  If a transient item is showing, initiates a new navigation
+  // to its URL.
+  virtual void Reload(ReloadType reload_type, bool check_for_repost) = 0;

[Eugene But (OOO till 7-30), 2017/03/10 18:37:32]

Content reload does not have this argument. Can we keep web API aligned with
content?

[kkhorimoto, 2017/03/10 18:47:46]

This is because content// stores the ReloadType in the NavigationEntry, which in
our discussions yesterday we decided was not the approach we wanted to go in, as
the reload behavior is transient and doesn't need to be stored with the
navigations in our history stack.  If we wanted to go with their approach, we
would need to add ReloadType::NONE, which is something we agreed that wouldn't
really be necessary if we went with this approach

[Eugene But (OOO till 7-30), 2017/03/10 18:58:04]

Sorry, I did not realize that proposed approach diverge us from content API. The
end goal is to have common API for content and web. Having less API in web is
fine, adding API which is not compatible with content should be the last resort.


Can we talk to content folks and ask if they would be fine with adding
|ReloadType| to their Reload API? It would be very unfortunate if we change
NavigationManager::Reload now and be forced to change it again later.

[liaoyuke, 2017/03/10 21:16:23]

Acknowledged.

 
   // Forces the pending item to be loaded using desktop user agent. Note that
   // the pending item may or may not already exist.
   // TODO(crbug.com/692303): Remove this when overriding the user agent doesn't
   // create a new NavigationItem.
   virtual void OverrideDesktopUserAgentForNextPendingItem() = 0;
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_PUBLIC_NAVIGATION_MANAGER_H_