created web::ReloadType

ios/web/navigation/navigation_manager_impl.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_manager_impl.h"
 
 #include <stddef.h>
 
 #include <utility>
 
 #include "base/logging.h"
 #import "ios/web/navigation/crw_session_controller+private_constructors.h"
 #import "ios/web/navigation/crw_session_controller.h"
 #import "ios/web/navigation/navigation_item_impl.h"
 #import "ios/web/navigation/navigation_item_impl_list.h"
 #import "ios/web/navigation/navigation_manager_delegate.h"
 #include "ios/web/navigation/navigation_manager_facade_delegate.h"
 #include "ios/web/public/load_committed_details.h"
 #import "ios/web/public/navigation_item.h"
+#include "ios/web/public/reload_type.h"
 #import "ios/web/public/web_client.h"
 #import "ios/web/public/web_state/web_state.h"
 #include "ui/base/page_transition_types.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 
@@ skipping 300 matching lines @@
 }
 
 void NavigationManagerImpl::GoForward() {
   delegate_->GoToIndex(GetIndexForOffset(1));
 }
 
 void NavigationManagerImpl::GoToIndex(int index) {
   delegate_->GoToIndex(index);
 }
 
-void NavigationManagerImpl::Reload(bool check_for_reposts) {
+void NavigationManagerImpl::Reload(ReloadType reload_type,
+                                   bool check_for_reposts) {
   // Navigation manager may be empty if the only pending item failed to load
   // with SSL error and the user has decided not to proceed.
   NavigationItem* item = GetVisibleItem();
   GURL url = item ? item->GetURL() : GURL(url::kAboutBlankURL);

[kkhorimoto, 2017/03/10 21:26:45]

Do you want to just update the logic here in this CL?  It should be as simple as
adding an extra condition here and using the original request URL depending on
the reload type.

[liaoyuke, 2017/03/10 21:42:34]

The |Reload| function in navigation manager is not doing reload, instead, it
calls LoadURLWithParams, which is wrong. I want to fix the problem first before
adding the user agent logic to avoid any surprising behaviors.

[kkhorimoto, 2017/03/10 22:24:59]

Okay that's fine.  Can you add the details of how you're going to refactor
Reload() to your design doc + add a TODO to fix the reload type?

   web::Referrer referrer = item ? item->GetReferrer() : web::Referrer();
 
   WebState::OpenURLParams params(url, referrer,
                                  WindowOpenDisposition::CURRENT_TAB,
                                  ui::PAGE_TRANSITION_RELOAD, NO);
   delegate_->GetWebState()->OpenURL(params);
 }
 
 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
 NavigationManagerImpl::GetTransientURLRewriters() {
@@ skipping 90 matching lines @@
   const ScopedNavigationItemImplList& items = [session_controller_ items];
   while (index >= 0) {
     NavigationItem* item = items[index--].get();
     if (!client->IsAppSpecificURL(item->GetVirtualURL()))
       return item;
   }
   return nullptr;
 }
 
 }  // namespace web