Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: content/browser/media/session/media_session_service_impl_browsertest.cc

Issue 2742923002: Use SameDocument term in tests instead of SamePage. (Closed)
Patch Set: Addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/session/media_session_service_impl_browsertest.cc
diff --git a/content/browser/media/session/media_session_service_impl_browsertest.cc b/content/browser/media/session/media_session_service_impl_browsertest.cc
index cfbdef154d6375106624bb47829e1eb0d21f1c30..90d4375ab05287a3e557db0bf6c566e0dfff0d53 100644
--- a/content/browser/media/session/media_session_service_impl_browsertest.cc
+++ b/content/browser/media/session/media_session_service_impl_browsertest.cc
@@ -175,17 +175,17 @@ IN_PROC_BROWSER_TEST_F(MediaSessionServiceImplBrowserTest,
}
IN_PROC_BROWSER_TEST_F(MediaSessionServiceImplBrowserTest,
- DontResetServiceForSamePageNavigation) {
+ DontResetServiceForSameDocumentNavigation) {
NavigateToURL(shell(), GetTestUrl(".", "title1.html"));
EnsurePlayer();
EXPECT_TRUE(ExecuteScriptToSetUpMediaSessionSync());
- // Start a same-page navigation and check the playback state, metadata,
+ // Start a fragment navigation and check the playback state, metadata,
// actions are not reset.
- GURL same_page_url = GetTestUrl(".", "title1.html");
- same_page_url = GURL(same_page_url.spec() + "#some-anchor");
- NavigateToURLAndWaitForFinish(shell(), same_page_url);
+ GURL fragment_change_url = GetTestUrl(".", "title1.html");
+ fragment_change_url = GURL(fragment_change_url.spec() + "#some-anchor");
+ NavigateToURLAndWaitForFinish(shell(), fragment_change_url);
EXPECT_EQ(blink::mojom::MediaSessionPlaybackState::PLAYING,
GetService()->playback_state());
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698