Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2742913004: Fix errors in summary_builder.dart. (Closed)

Created:
3 years, 9 months ago by Paul Berry
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix errors in summary_builder.dart. Due to a race between landing a85cdfc50f57009b9e91d1734ee7504bdfdec088 and f8588ba47c9e52cca69f37df974a82697831ac60, summary_builder wound up with the wrong number of arguments for endLiteralString(). Not sure why this wasn't caught by buildbots. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/bf83a2745bc6ac6d45bc645151c5cbdfad9d3020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M pkg/analyzer/lib/src/summary/fasta/summary_builder.dart View 15 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 9 months ago (2017-03-10 17:52:34 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-10 18:45:21 UTC) #3
Paul Berry
3 years, 9 months ago (2017-03-10 20:12:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf83a2745bc6ac6d45bc645151c5cbdfad9d3020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698