Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/welcome/win10/inline.html

Issue 2742833002: [Win10 FRE] Fix ARIA attributes to conform to accordion widget. (Closed)
Patch Set: Remove redundant attributes; fix spacing. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/welcome/win10/inline.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <title>$i18n{headerText}</title> 5 <title>$i18n{headerText}</title>
6 6
7 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 7 <link rel="import" href="chrome://resources/cr_elements/icons.html">
8 <link rel="import" href="chrome://resources/html/cr.html"> 8 <link rel="import" href="chrome://resources/html/cr.html">
9 <link rel="import" href="chrome://resources/html/action_link.html"> 9 <link rel="import" href="chrome://resources/html/action_link.html">
10 <link rel="import" href="chrome://resources/html/action_link_css.html"> 10 <link rel="import" href="chrome://resources/html/action_link_css.html">
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 263
264 #edge-overlay { 264 #edge-overlay {
265 font-size: 9px; 265 font-size: 9px;
266 } 266 }
267 267
268 #taskbar-overlay { 268 #taskbar-overlay {
269 font-size: 12.2px; 269 font-size: 12.2px;
270 } 270 }
271 } 271 }
272 </style> 272 </style>
273 <div class="header-logo"></div> 273 <div class="header-logo" role="presentation"></div>
274 <div class="heading">$i18n{headerText}</div> 274 <div class="heading">$i18n{headerText}</div>
275 <div class="sections"> 275 <div class="sections">
276 <div class$="[[computeClasses(isCombined)]]"> 276 <div class$="[[computeClasses(isCombined)]]">
277 <template is="dom-if" if="[[isCombined]]"> 277 <template is="dom-if" if="[[isCombined]]">
278 <a is="action-link" class="section-heading" on-tap="onToggle"> 278 <div role="heading" aria-level="2">
279 <div class="section-heading-text"> 279 <a id="tab1" is="action-link" class="section-heading"
280 $i18n{defaultBrowserSubheaderText} 280 on-tap="onToggle" role="button" area-controls="panel1"
dmazzoni 2017/03/10 19:36:53 area-controls -> aria-controls
huangs 2017/03/10 19:42:53 Hmm weird, I searched and failed to find this. Tha
281 </div> 281 aria-expanded="true">
282 <iron-icon class="section-heading-expand" icon="cr:expand-more"> 282 <div class="section-heading-text" role="presentation">
283 </iron-icon> 283 $i18n{defaultBrowserSubheaderText}
284 </a> 284 </div>
285 <iron-icon class="section-heading-expand" icon="cr:expand-more"
286 role="presentation">
287 </iron-icon>
288 </a>
289 </div>
285 </template> 290 </template>
286 <template is="dom-if" if="[[!isCombined]]"> 291 <template is="dom-if" if="[[!isCombined]]">
287 <div class="section-heading"> 292 <div class="section-heading" role="text">
288 <div class="section-heading-text"> 293 <div class="section-heading-text" role="presentation">
289 $i18n{defaultBrowserSubheaderText} 294 $i18n{defaultBrowserSubheaderText}
290 </div> 295 </div>
291 </div> 296 </div>
292 </template> 297 </template>
293 <ol class="section-steps"> 298 <ol id="panel1" class="section-steps" aria-labelledby="tab1">
294 <li> 299 <li>
295 <a is="action-link" on-tap="onOpenSettings"> 300 <a is="action-link" on-tap="onOpenSettings" role="link">
296 $i18n{openSettingsText} 301 $i18n{openSettingsText}
297 </a> 302 </a>
298 </li> 303 </li>
299 <li> 304 <li>
300 <div>$i18nRaw{clickEdgeText}</div> 305 <div role="presentation">$i18nRaw{clickEdgeText}</div>
301 <div class="screenshot-image" id="default-image"> 306 <div class="screenshot-image" id="default-image"
307 role="presentation">
302 <div class="screenshot-overlay" id="browser-overlay"> 308 <div class="screenshot-overlay" id="browser-overlay">
303 <div aria-hidden="true">$i18n{webBrowserLabel}</div> 309 <div aria-hidden="true">$i18n{webBrowserLabel}</div>
304 </div> 310 </div>
305 <div class="screenshot-overlay" id="edge-overlay"> 311 <div class="screenshot-overlay" id="edge-overlay">
306 <div aria-hidden="true">$i18n{microsoftEdgeLabel}</div> 312 <div aria-hidden="true">$i18n{microsoftEdgeLabel}</div>
307 </div> 313 </div>
308 </div> 314 </div>
309 </li> 315 </li>
310 <li>$i18nRaw{clickSelectChrome}</li> 316 <li>
317 <div role="presentation">$i18nRaw{clickSelectChrome}</div>
318 </li>
311 </ol> 319 </ol>
312 </div> 320 </div>
313 <template is="dom-if" if="[[isCombined]]"> 321 <template is="dom-if" if="[[isCombined]]">
314 <div class="section expandable"> 322 <div class="section expandable">
315 <a is="action-link" class="section-heading" on-tap="onToggle"> 323 <div role="heading" aria-level="2">
316 <div class="section-heading-text">$i18n{pinSubheaderText}</div> 324 <a id="tab2" is="action-link" class="section-heading"
317 <iron-icon class="section-heading-expand" icon="cr:expand-more"> 325 on-tap="onToggle" role="button" aria-controls="panel2"
318 </iron-icon> 326 aria-expanded="false">
319 </a> 327 <div class="section-heading-text" role="presentation">
320 <ol class="section-steps"> 328 $i18n{pinSubheaderText}
329 </div>
330 <iron-icon class="section-heading-expand" icon="cr:expand-more"
331 role="presentation">
332 </iron-icon>
333 </a>
334 </div>
335 <ol id="panel2" class="section-steps" aria-labelledby="tab2">
321 <li>$i18nRaw{rightClickText}</li> 336 <li>$i18nRaw{rightClickText}</li>
322 <li> 337 <li>
323 <div>$i18nRaw{pinInstructionText}</div> 338 <div role="presentation">$i18nRaw{pinInstructionText}</div>
324 <div class="screenshot-image" id="taskbar-image"> 339 <div class="screenshot-image" id="taskbar-image"
340 role="presentation">
325 <div class="screenshot-overlay" id="taskbar-overlay"> 341 <div class="screenshot-overlay" id="taskbar-overlay">
326 <div aria-hidden="true">$i18n{pinToTaskbarLabel}</div> 342 <div aria-hidden="true">$i18n{pinToTaskbarLabel}</div>
327 </div> 343 </div>
328 <div class="screenshot-overlay" id="icon-overlay"> 344 <div class="screenshot-overlay" id="icon-overlay">
329 </div> 345 </div>
330 </div> 346 </div>
331 </li> 347 </li>
332 </ol> 348 </ol>
333 </div> 349 </div>
334 </template> 350 </template>
335 </div> 351 </div>
336 <paper-button class="button" on-tap="onContinue"> 352 <paper-button class="button" on-tap="onContinue">
337 $i18n{continueText} 353 $i18n{continueText}
338 </paper-button> 354 </paper-button>
339 </template> 355 </template>
340 <script src="/welcome.js"></script> 356 <script src="/welcome.js"></script>
341 </dom-module> 357 </dom-module>
342 </head> 358 </head>
343 <body> 359 <body>
344 <welcome-win10-inline></welcome-win10-inline> 360 <welcome-win10-inline></welcome-win10-inline>
345 </body> 361 </body>
346 </html> 362 </html>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/welcome/win10/inline.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698