[Mac] Lay out the browser window when adding the download shelf.

chrome/browser/ui/cocoa/browser_window_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 
 // A class acting as the Objective-C controller for the Browser
 // object. Handles interactions between Cocoa and the cross-platform
 // code. Each window has a single toolbar and, by virtue of being a
 // TabWindowController, a tab strip along the top.
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
 #include "base/mac/scoped_nsobject.h"
 #include "chrome/browser/extensions/browser_extension_window_controller.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
+#include "chrome/browser/ui/browser.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #import "chrome/browser/ui/cocoa/url_drop_target.h"
 #import "chrome/browser/ui/cocoa/view_resizer.h"
 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
 #include "chrome/browser/ui/tabs/tab_utils.h"
 #include "components/translate/core/common/translate_errors.h"
 #include "ui/base/accelerators/accelerator_manager.h"
 #include "ui/gfx/geometry/rect.h"
 
 @class AvatarBaseController;
 class BookmarkBubbleObserverCocoa;
-class Browser;
 class BrowserWindow;
 class BrowserWindowCocoa;
 @class BrowserWindowFullscreenTransition;
 @class BrowserWindowTouchBar;
 @class DevToolsController;
 @class DownloadShelfController;
 class ExtensionKeybindingRegistryCocoa;
 class ExclusiveAccessController;
 class ExclusiveAccessContext;
 @class FindBarCocoaController;
@@ skipping 12 matching lines @@
 @class TranslateBubbleController;
 
 namespace content {
 class WebContents;
 }
 
 namespace extensions {
 class Command;
 }
 
+inline NSSize MinWindowSizeForBrowserType(Browser::Type type) {

[tapted, 2017/03/13 00:25:36]

See later comment for details, but I think we need/want something like

constexpr const gfx::Size kMinCocoaTabbedWindowSize = gfx::Size(400, 272);
constexpr const gfx::Size kMinCocoaPopupWindowSize = gfx::Size(100, 122);

(you'll probably need to define them without an initializer in the .cc so they
have "storage" space)

You can call .ToCGSize() to get an NSSize.

constexpr const NSSize kFoo = {400, 272}; 

might also work. NSMakeSize: probably not (but maybe) - see later comment.

[Sidney San Martín, 2017/03/14 23:28:39]

Done. I don't think they need storage space
(http://stackoverflow.com/questions/34445336/).

+  switch (type) {
+    case Browser::TYPE_TABBED:
+      return NSMakeSize(400, 272);
+    case Browser::TYPE_POPUP:
+      return NSMakeSize(100, 122);
+  }
+}
+
 @interface BrowserWindowController
     : TabWindowController<BookmarkBarControllerDelegate,
                           ViewResizer,
                           TabStripControllerDelegate> {
  @private
   // The ordering of these members is important as it determines the order in
   // which they are destroyed. |browser_| needs to be destroyed last as most of
   // the other objects hold weak references to it or things it owns
   // (tab/toolbar/bookmark models, profiles, etc).
   std::unique_ptr<Browser> browser_;
@@ skipping 533 matching lines @@
 // Returns the fullscreen toolbar controller.
 - (FullscreenToolbarController*)fullscreenToolbarController;
 
 // Sets the fullscreen toolbar controller.
 - (void)setFullscreenToolbarController:(FullscreenToolbarController*)controller;
 
 @end  // @interface BrowserWindowController (TestingAPI)
 
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_H_