Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2742793002: Update status file to account for yet another alias for the VM. (Closed)

Created:
3 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 7 months ago
Reviewers:
Bill Hesse, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status file to account for yet another alias for the VM. Committed: https://github.com/dart-lang/sdk/commit/294ea61bec222ebb95a08cf4f7bbc4b889afca73

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/language.status View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
TBR
3 years, 9 months ago (2017-03-09 15:11:50 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 294ea61bec222ebb95a08cf4f7bbc4b889afca73 (presubmit successful).
3 years, 9 months ago (2017-03-09 15:12:46 UTC) #4
floitsch
LGTM.
3 years, 9 months ago (2017-03-09 15:14:45 UTC) #5
Bill Hesse
3 years, 7 months ago (2017-05-15 13:23:50 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2742793002/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/2742793002/diff/1/tests/language/language.sta...
tests/language/language.status:317: [ ($runtime == vm || $runtime ==
dart_precompiled || $runtime == dartium || $runtime == drt) || ($compiler ==
none || $compiler == app_jit) ]
I don't see why you need both the $compiler check and the $runtime check.  Or
did you mean to and them together?  The runtime check should be sufficient.

Powered by Google App Engine
This is Rietveld 408576698