Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: cc/layers/render_surface_unittest.cc

Issue 2742743003: Delete RenderPassSink (Closed)
Patch Set: Refine unittest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/trees/layer_tree_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/render_surface_unittest.cc
diff --git a/cc/layers/render_surface_unittest.cc b/cc/layers/render_surface_unittest.cc
index 85ed8c4294a534a149e62064e04c63c3d89f08a0..281a6d56ca3b1f588dd75240f7ec18b97fe5fa5d 100644
--- a/cc/layers/render_surface_unittest.cc
+++ b/cc/layers/render_surface_unittest.cc
@@ -4,7 +4,6 @@
#include "cc/layers/append_quads_data.h"
#include "cc/layers/layer_impl.h"
-#include "cc/layers/render_pass_sink.h"
#include "cc/layers/render_surface_impl.h"
#include "cc/quads/shared_quad_state.h"
#include "cc/test/fake_compositor_frame_sink.h"
@@ -152,19 +151,6 @@ TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectSharedQuadState) {
EXPECT_EQ(blend_mode, shared_quad_state->blend_mode);
}
-class TestRenderPassSink : public RenderPassSink {
- public:
- void AppendRenderPass(std::unique_ptr<RenderPass> render_pass) override {
- render_passes_.push_back(std::move(render_pass));
- }
-
- const RenderPassList& RenderPasses() const {
- return render_passes_;
- }
-
- private:
- RenderPassList render_passes_;
-};
TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectRenderPass) {
FakeImplTaskRunnerProvider task_runner_provider;
@@ -199,12 +185,7 @@ TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectRenderPass) {
render_surface->SetScreenSpaceTransform(origin);
render_surface->SetContentRectForTesting(content_rect);
- TestRenderPassSink pass_sink;
-
- render_surface->AppendRenderPasses(&pass_sink);
-
- ASSERT_EQ(1u, pass_sink.RenderPasses().size());
- RenderPass* pass = pass_sink.RenderPasses()[0].get();
+ auto pass = render_surface->CreateRenderPass();
EXPECT_EQ(2, pass->id);
EXPECT_EQ(content_rect, pass->output_rect);
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/trees/layer_tree_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698