cc/layers/render_surface_unittest.cc - Issue 2742743003: Delete RenderPassSink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/render_surface_unittest.cc

Issue 2742743003: Delete RenderPassSink (Closed)

Patch Set: Rename AppendRenderPasses to CreateRenderPass Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/render_surface_unittest.cc

diff --git a/cc/layers/render_surface_unittest.cc b/cc/layers/render_surface_unittest.cc

index 85ed8c4294a534a149e62064e04c63c3d89f08a0..f2fc566d724f6b2b913a5da3209c7f32f1197a5f 100644

--- a/cc/layers/render_surface_unittest.cc

+++ b/cc/layers/render_surface_unittest.cc

@@ -201,7 +201,7 @@ TEST(RenderSurfaceTest, SanityCheckSurfaceCreatesCorrectRenderPass) {

TestRenderPassSink pass_sink;

danakj 2017/03/14 15:14:34 Delete this. And delete the class from cc/test/

- render_surface->AppendRenderPasses(&pass_sink);

+ pass_sink.AppendRenderPass(render_surface->CreateRenderPass());

ASSERT_EQ(1u, pass_sink.RenderPasses().size());

danakj 2017/03/14 15:14:34 delete, there can only be 1

RenderPass* pass = pass_sink.RenderPasses()[0].get();