Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2742733002: [kernel] Don't assume to have source (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Reviewers:
erikcorry, karlklose
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jensj
Previously we included the source in kernel. With fasta we don't (currently at least) do ...
3 years, 9 months ago (2017-03-09 07:48:35 UTC) #2
jensj
3 years, 9 months ago (2017-03-09 08:20:28 UTC) #4
karlklose
LGTM
3 years, 9 months ago (2017-03-09 08:43:58 UTC) #5
jensj
3 years, 9 months ago (2017-03-09 08:49:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5812e69c3af88c97767e7ad9510f6f2dca3ce398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698