Use the native frame for the task manager on Linux Aura

Use the native frame for the task manager on Linux Aura

BUG=348437
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271086

[pkotwicz, 2014-05-11 02:14:09]

Elliot, can you please take a look?

[Elliot Glaysher, 2014-05-12 19:34:29]

lgtm

[pkotwicz, 2014-05-12 23:40:19]

sadrul@ for ui/views OWNERS
benwells@ for chrome/browser/ui/views/apps OWNERS

[Matt Giuca, 2014-05-12 23:42:40]

I'd like to take a look at this as well, since I wrote a lot of the underlying
code.

[Matt Giuca, 2014-05-12 23:44:24]

Can you change the BUG= to 348437 (the one you currently have is a duplicate).

[benwells, 2014-05-13 00:31:09]

On 2014/05/12 23:44:24, Matt Giuca wrote:
> Can you change the BUG= to 348437 (the one you currently have is a duplicate).

I'll wait for mgiuca on this one.

[Matt Giuca, 2014-05-13 09:09:54]

Hi Peter,

FYI, I had a look over it. Looks like a very nice simplification (removing a
bunch of Linux-specific logic). I'd like to have a bit more of a think about
this (refresh my memory on some of these concepts) which I will do tomorrow.
Sorry about the delay.

Matt

[Matt Giuca, 2014-05-14 06:16:09]

OK LGTM, and thanks for doing this! It's really nice that Linux and Windows now
share a lot more code for getting to native frames.

I was hoping this would fix the color picker as well, but I tested it and it
doesn't. Oh well, we can fix that one after this patch goes in
(http://crbug.com/366952).

[Matt Giuca, 2014-05-14 06:16:38]

Some nits (didn't get sent with my previous comment).

https://codereview.chromium.org/274273004/diff/40001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right):

https://codereview.chromium.org/274273004/diff/40001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:540: return
desktop_window_tree_host_->ShouldUseNativeFrame() ?
Can you just call ShouldUseNativeFrame instead of
desktop_window_tree_host_->ShouldUseNativeFrame()?

https://codereview.chromium.org/274273004/diff/40001/ui/views/window/native_f...
File ui/views/window/native_frame_view.cc (right):

https://codereview.chromium.org/274273004/diff/40001/ui/views/window/native_f...
ui/views/window/native_frame_view.cc:48: window_bounds.set_height(1);
Optional suggestion: window_bounds.set_size(gfx::Size(1, 1));

[pkotwicz, 2014-05-15 15:56:46]

I have addressed Matt's nits.

benwells@, sadrul@ ping!

[benwells, 2014-05-16 01:03:27]

lgtm, apps change looks nice :)

[sadrul, 2014-05-16 02:22:47]

LGTM

[pkotwicz, 2014-05-16 16:01:47]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-16 16:02:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/274273004/60001

[commit-bot: I haz the power, 2014-05-16 19:57:23]

Change committed as 271086