Create a temp download direcgtory for BrowserCloseManagerBrowserTests

Create a temp download directory for BrowserCloseManagerBrowserTests

These browser_tests were writing to the current user's downloads
directory. While this is bad in itself, it is also suspected as the
cause of test failures on the waterfall.

BUG=372017
R=jamescook@chromium.org
TBR=jam

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269536

[James Cook, 2014-05-10 04:23:18]

LGTM with optional nits. If you want to just commit this and see if helps the
bot, go ahead - the nits could be fixed in a later CL.

Or fix the nits and dcommit - I'm not asking for any functional changes.

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
File chrome/browser/lifetime/browser_close_manager_browsertest.cc (right):

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
chrome/browser/lifetime/browser_close_manager_browsertest.cc:701: class
BrowserCloseManagerBrowserTestWithDownloads :
nit: I would call this BrowserCloseManagerWithDownloadsBrowserTest (or just
BrowserCloseManagerWithDownloadsTest) for symmetry with
BrowserCloseManagerWithBackgroundModeBrowserTest below.

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
chrome/browser/lifetime/browser_close_manager_browsertest.cc:704: virtual void
SetUpOnMainThread() OVERRIDE {
nit: maybe add BrowserCloseManagerWithDownloadsBrowserTest() {} and virtual
~BrowserCloseManagerWithDownloadsBrowserTest() {} ?

[James Cook, 2014-05-10 04:24:23]

Also, for other people looking at this -- this shouldn't affect the Webstore
browser test failures, just the BrowserCloseManager ones.

[asanka, 2014-05-10 04:32:27]

Thanks!

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
File chrome/browser/lifetime/browser_close_manager_browsertest.cc (right):

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
chrome/browser/lifetime/browser_close_manager_browsertest.cc:701: class
BrowserCloseManagerBrowserTestWithDownloads :
On 2014/05/10 04:23:18, James Cook wrote:
> nit: I would call this BrowserCloseManagerWithDownloadsBrowserTest (or just
> BrowserCloseManagerWithDownloadsTest) for symmetry with
> BrowserCloseManagerWithBackgroundModeBrowserTest below.

Done.

https://codereview.chromium.org/274273003/diff/1/chrome/browser/lifetime/brow...
chrome/browser/lifetime/browser_close_manager_browsertest.cc:704: virtual void
SetUpOnMainThread() OVERRIDE {
On 2014/05/10 04:23:18, James Cook wrote:
> nit: maybe add BrowserCloseManagerWithDownloadsBrowserTest() {} and virtual
> ~BrowserCloseManagerWithDownloadsBrowserTest() {} ?

Done.

[asanka, 2014-05-10 05:52:08]

Committed patchset #2 manually as r269536 (tree was closed).