Views: Reverse Tab order of Download Shelf Items

chrome/browser/ui/views/download/download_shelf_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_shelf_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 96 matching lines @@
 
 DownloadShelfView::~DownloadShelfView() {
   parent_->RemoveChildView(this);
 }
 
 void DownloadShelfView::AddDownloadView(DownloadItemView* view) {
   mouse_watcher_.Stop();
 
   DCHECK(view);
   download_views_.push_back(view);
-  AddChildView(view);
+
+  // Insert the new view at index 0 to maintain a newest to oldest tab order.

[Peter Kasting, 2014/05/22 18:23:14]

Nit: How about:

Insert the new view as the first child, so the logical child order matches the
visual order.  This ensures that e.g. tabbing through downloads happens in the
order users would expect.

+  AddChildViewAt(view, 0);
   if (download_views_.size() > kMaxDownloadViews)
     RemoveDownloadView(*download_views_.begin());
 
   new_item_animation_->Reset();
   new_item_animation_->Show();
 }
 
 void DownloadShelfView::DoAddDownload(DownloadItem* download) {
   DownloadItemView* view = new DownloadItemView(download, this);
   AddDownloadView(view);
@@ skipping 14 matching lines @@
   if (download_views_.empty())
     Close(AUTOMATIC);
   else if (CanAutoClose())
     mouse_watcher_.Start();
   Layout();
   SchedulePaint();
 }
 
 views::View* DownloadShelfView::GetDefaultFocusableChild() {
   return download_views_.empty() ?
-      static_cast<View*>(show_all_view_) : download_views_[0];
+      static_cast<View*>(show_all_view_) :
+      download_views_[download_views_.size() - 1];

[Peter Kasting, 2014/05/22 18:23:14]

Nit: download_views_.back()

 }
 
 void DownloadShelfView::OnPaintBorder(gfx::Canvas* canvas) {
   canvas->FillRect(gfx::Rect(0, 0, width(), 1), kBorderColor);
 }
 
 void DownloadShelfView::OpenedDownload(DownloadItemView* view) {
   if (CanAutoClose())
     mouse_watcher_.Start();
 }
@@ skipping 251 matching lines @@
   }
 }
 
 bool DownloadShelfView::CanAutoClose() {
   for (size_t i = 0; i < download_views_.size(); ++i) {
     if (!download_views_[i]->download()->GetOpened())
       return false;
   }
   return true;
 }