Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2011 Google Inc. All rights reserved. | 2 * Copyright (C) 2011 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 797 this._valueWidgets.set(i, widget); | 797 this._valueWidgets.set(i, widget); |
| 798 this.textEditor.addDecoration(widget, i); | 798 this.textEditor.addDecoration(widget, i); |
| 799 } | 799 } |
| 800 } | 800 } |
| 801 } | 801 } |
| 802 | 802 |
| 803 clearExecutionLine() { | 803 clearExecutionLine() { |
| 804 if (this.loaded && this._executionLocation) | 804 if (this.loaded && this._executionLocation) |
| 805 this.textEditor.clearExecutionLine(); | 805 this.textEditor.clearExecutionLine(); |
| 806 delete this._executionLocation; | 806 delete this._executionLocation; |
| 807 this._clearValueWidgetsTimer = setTimeout(this._clearValueWidgets.bind(this) , 1000); | 807 this._clearValueWidgetsTimer = setTimeout(this._clearValueWidgets.bind(this) , 1000); |
|
lushnikov
2017/03/10 01:38:16
don't you want the same for inline values?
| |
| 808 if (Runtime.experiments.isEnabled('continueToLocationMarkers')) | 808 if (Runtime.experiments.isEnabled('continueToLocationMarkers')) { |
| 809 if (this._clearContinueToLocationsTimer) | |
| 810 clearTimeout(this._clearContinueToLocationsTimer); | |
|
lushnikov
2017/03/10 01:38:16
let's rather fix the original root of the problem!
| |
| 809 this._clearContinueToLocationsTimer = setTimeout(this._clearContinueToLoca tions.bind(this), 1000); | 811 this._clearContinueToLocationsTimer = setTimeout(this._clearContinueToLoca tions.bind(this), 1000); |
| 812 } | |
| 810 } | 813 } |
| 811 | 814 |
| 812 _clearValueWidgets() { | 815 _clearValueWidgets() { |
| 813 delete this._clearValueWidgetsTimer; | 816 delete this._clearValueWidgetsTimer; |
| 814 for (var line of this._valueWidgets.keys()) | 817 for (var line of this._valueWidgets.keys()) |
| 815 this.textEditor.removeDecoration(this._valueWidgets.get(line), line); | 818 this.textEditor.removeDecoration(this._valueWidgets.get(line), line); |
| 816 this._valueWidgets.clear(); | 819 this._valueWidgets.clear(); |
| 817 } | 820 } |
| 818 | 821 |
| 819 _clearContinueToLocations() { | 822 _clearContinueToLocations() { |
| (...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1463 return; | 1466 return; |
| 1464 this.bookmark.clear(); | 1467 this.bookmark.clear(); |
| 1465 this.bookmark = null; | 1468 this.bookmark = null; |
| 1466 } | 1469 } |
| 1467 }; | 1470 }; |
| 1468 | 1471 |
| 1469 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); | 1472 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); |
| 1470 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); | 1473 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); |
| 1471 | 1474 |
| 1472 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); | 1475 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); |
| OLD | NEW |