Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 274263002: Reland: Support multiple sign-in for extension updates. (Closed)

Created:
6 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Reland: Support multiple sign-in for extension updates. This changes the ExtensionDownloader to attempt multiple sequential queries for CRX downloads, iterating over incremental values for the authuser query parameter up to a max of 10. This is a re-landing of http://codereview.chromium.org/279453002/ which was reverted due to a use-after-free bug in the unit tests. BUG=370964 R=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -23 lines) Patch
M chrome/browser/extensions/updater/extension_downloader.cc View 4 chunks +77 lines, -7 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 6 chunks +86 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Rockot(use gerrit already)
Note that this is the same patch as before, except the unit tests now reacquire ...
6 years, 7 months ago (2014-05-09 22:30:45 UTC) #1
asargent_no_longer_on_chrome
lgtm
6 years, 7 months ago (2014-05-09 23:22:32 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-09 23:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/274263002/1
6 years, 7 months ago (2014-05-09 23:31:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 03:42:12 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:07:31 UTC) #6
Message was sent while issue was closed.
Change committed as 269666

Powered by Google App Engine
This is Rietveld 408576698