third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js - Issue 2742623002: DevTools: improve test infrastructure w/ devtools driving the test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

Issue 2742623002: DevTools: improve test infrastructure w/ devtools driving the test (Closed)

Patch Set: fixup Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/layout_test/blink_test_controller.cc ('K') | « content/shell/test_runner/test_interfaces.cc ('k') | third_party/WebKit/LayoutTests/http/tests/inspector-unit/text-prompt.js » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector/devtools-js/release-note.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

index c17bec987eae998334af9c39e8d82fa4d29c02f0..3cc0887690c0bb1630909dfe7818cf96b0bc2991 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

@@ -28,7 +28,7 @@ function test() {

var filteredSelectionDialog = new QuickOpen.FilteredListWidget(delegate, history);

filteredSelectionDialog.showAsDialog();

- var promise = TestRunner.addSniffer(filteredSelectionDialog, "_itemsFilteredForTest").then(accept);

+ var promise = TestRunner.addSnifferPromise(filteredSelectionDialog, "_itemsFilteredForTest").then(accept);

filteredSelectionDialog.setQuery(query);

filteredSelectionDialog._updateAfterItemsLoaded();

return promise;