color: Always use parametric color spaces for raster

ui/gfx/color_transform.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/color_transform.h"
 
 #include <algorithm>
 #include <cmath>
 #include <list>
 #include <memory>
@@ skipping 728 matching lines @@
     steps_.push_back(base::MakeUnique<ColorTransformFromLinear>(to.transfer_));
   }
 
   steps_.push_back(
       base::MakeUnique<ColorTransformMatrix>(GetTransferMatrix(to)));
 
   steps_.push_back(
       base::MakeUnique<ColorTransformMatrix>(Invert(GetRangeAdjustMatrix(to))));
 }
 
+// TODO(ccameron): Change this to SkColorSpaceXform.
 class QCMSColorTransform : public ColorTransformStep {
  public:
   // Takes ownership of the profiles
   QCMSColorTransform(ScopedQcmsProfile from, ScopedQcmsProfile to)
       : from_(std::move(from)), to_(std::move(to)) {}
   ~QCMSColorTransform() override {}
   QCMSColorTransform* GetQCMS() override { return this; }
   bool Join(ColorTransformStep* next_untyped) override {
     QCMSColorTransform* next = next_untyped->GetQCMS();
     if (!next)
@@ skipping 22 matching lines @@
                          reinterpret_cast<float*>(colors), num * 3);
   }
 
  private:
   ScopedQcmsProfile from_;
   ScopedQcmsProfile to_;
 };
 
 ScopedQcmsProfile ColorTransformInternal::GetQCMSProfileIfNecessary(
     const ColorSpace& color_space) {
+  if (color_space.primaries_ != ColorSpace::PrimaryID::ICC_BASED &&
+      color_space.transfer_ != ColorSpace::TransferID::ICC_BASED) {
+    return nullptr;
+  }
+  // TODO(ccameron): Use SkColorSpaceXform here to avoid looking up the
+  // ICCProfile.
   ICCProfile icc_profile;
-  if (!ICCProfile::FromId(color_space.icc_profile_id_, true, &icc_profile))
-    return nullptr;
+  if (!ICCProfile::FromId(color_space.icc_profile_id_, &icc_profile)) {
+    // We needed the original ICC profile to construct this transform, but it
+    // has been flushed from our cache. Fall back to using the ICC profile's
+    // inaccurate, so spam the console.
+    // TODO(ccameron): This will go away when we switch to SkColorSpaceXform.
+    LOG(ERROR) << "Failed to retrieve original ICC profile, using sRGB";
+    return ScopedQcmsProfile(qcms_profile_sRGB());
+  }
   return ScopedQcmsProfile(qcms_profile_from_memory(
       icc_profile.GetData().data(), icc_profile.GetData().size()));
 }
 
 ScopedQcmsProfile GetXYZD50Profile() {
   // QCMS is trixy, it has a datatype called qcms_CIE_xyY, but what it expects
   // is in fact not xyY color coordinates, it just wants the x/y values of the
   // primaries with Y equal to 1.0.
   qcms_CIE_xyYTRIPLE xyz;
   qcms_CIE_xyY w;
@@ skipping 109 matching lines @@
     const ColorSpace& to,
     Intent intent) {
   return std::unique_ptr<ColorTransform>(
       new ColorTransformInternal(from, to, intent));
 }
 
 ColorTransform::ColorTransform() {}
 ColorTransform::~ColorTransform() {}
 
 }  // namespace gfx