Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2954)

Unified Diff: chrome/test/data/webui/md_bookmarks/list_test.js

Issue 2742583003: MD Bookmarks: Extract bookmark editing into a <bookmark-edit-dialog> element (Closed)
Patch Set: Rename event handlers Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/list_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/list_test.js b/chrome/test/data/webui/md_bookmarks/list_test.js
index a2cd6f9ccd61e2154b16d11056a05dac81cf9154..155f27761ecc8b8d72a1822611288926ccd85be5 100644
--- a/chrome/test/data/webui/md_bookmarks/list_test.js
+++ b/chrome/test/data/webui/md_bookmarks/list_test.js
@@ -25,40 +25,6 @@ suite('<bookmarks-list>', function() {
Polymer.dom.flush();
});
- test('folder menu item hides the url field', function() {
- // Bookmark editor shows the url field.
- list.menuItem_ = store.data.nodes['1'];
- assertFalse(list.$['url'].hidden);
-
- // Folder editor hides the url field.
- list.menuItem_ = store.data.nodes['3'];
- assertTrue(list.$['url'].hidden);
- });
-
- test('saving edit passes correct details to the update', function() {
- // Saving bookmark edit.
- var menuItem = store.data.nodes['1'];
- chrome.bookmarks.update = function(id, edit) {
- assertEquals(menuItem.id, id);
- assertEquals(menuItem.url, edit.url);
- assertEquals(menuItem.title, edit.title);
- };
- list.menuItem_ = menuItem;
- list.$.editBookmark.showModal();
- MockInteractions.tap(list.$.saveButton);
-
- // Saving folder rename.
- menuItem = store.data.nodes['3'];
- chrome.bookmarks.update = function(id, edit) {
- assertEquals(menuItem.id, id);
- assertEquals(menuItem.title, edit.title);
- assertEquals(undefined, edit.url);
- };
- list.menuItem_ = menuItem;
- list.$.editBookmark.showModal();
- MockInteractions.tap(list.$.saveButton);
- });
-
test('renders correct <bookmark-item> elements', function() {
var items = list.root.querySelectorAll('bookmarks-item');
var ids = Array.from(items).map((item) => item.itemId);

Powered by Google App Engine
This is Rietveld 408576698