Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2625)

Unified Diff: chrome/browser/resources/md_bookmarks/list.html

Issue 2742583003: MD Bookmarks: Extract bookmark editing into a <bookmark-edit-dialog> element (Closed)
Patch Set: Rename event handlers Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/edit_dialog.js ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/list.html
diff --git a/chrome/browser/resources/md_bookmarks/list.html b/chrome/browser/resources/md_bookmarks/list.html
index d36a1f4941b5eb1a329b7d980c617d9bb2f565f3..05bb41182f199536d1cee8116a7424b7bb67f45a 100644
--- a/chrome/browser/resources/md_bookmarks/list.html
+++ b/chrome/browser/resources/md_bookmarks/list.html
@@ -1,11 +1,9 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
-<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
-<link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_render.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.html">
+<link rel="import" href="chrome://bookmarks/edit_dialog.html">
<link rel="import" href="chrome://bookmarks/item.html">
<link rel="import" href="chrome://bookmarks/shared_style.html">
<link rel="import" href="chrome://bookmarks/store_client.html">
@@ -13,7 +11,7 @@
<dom-module id="bookmarks-list">
<template>
- <style include="shared-style cr-shared-style">
+ <style include="shared-style">
:host {
overflow-y: auto;
padding: 20px 32px 20px calc(32px - var(--splitter-width));
@@ -49,29 +47,6 @@
$i18n{menuDelete}
</button>
</dialog>
- <dialog is="cr-dialog" id="editBookmark">
- <div class="title">[[getEditorTitle_(menuItem_)]]</div>
- <div class="body">
- <paper-input always-float-label id="name"
- label="$i18n{editDialogNameInput}"
- value="{{menuItem_.title}}">
- </paper-input>
- <paper-input always-float-label id="url"
- label="$i18n{editDialogUrlInput}"
- value="{{menuItem_.url}}"
- hidden$="[[!menuItem_.url]]">
- </paper-input>
- </div>
- <div class="button-container">
- <paper-button class="cancel-button" on-tap="onCancelEditTap_">
- $i18n{cancelEdit}
- </paper-button>
- <paper-button class="action-button" on-tap="onSaveEditTap_"
- id='saveButton'>
- $i18n{saveEdit}
- </paper-button>
- </div>
- </dialog>
<div id="bookmarksCard" hidden$="[[isEmptyList_(displayedList_.length)]]">
<template is="dom-repeat" items="[[displayedList_]]" as="id">
<bookmarks-item item-id="[[id]]">
@@ -82,6 +57,9 @@
hidden$="[[!isEmptyList_(displayedList_.length)]]">
[[emptyListMessage_(searchTerm_)]]
</div>
+ <template is="cr-lazy-render" id="editDialog">
+ <bookmarks-edit-dialog></bookmarks-edit-dialog>
+ </template>
</template>
<script src="chrome://bookmarks/list.js"></script>
</dom-module>
« no previous file with comments | « chrome/browser/resources/md_bookmarks/edit_dialog.js ('k') | chrome/browser/resources/md_bookmarks/list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698