third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js - Issue 2742573007: DevTools: initial console suggestion should be greyed out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

Issue 2742573007: DevTools: initial console suggestion should be greyed out (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js b/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

index f0f76cf6b43a12efdf028f07742f6ed9af8b6f0b..25c6b226537c399a6fe6ec6a41f44dcffa507dc3 100644

--- a/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

+++ b/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

@@ -250,8 +250,10 @@ TextEditor.TextEditorAutocompleteController = class {

this._onSuggestionsShownForTest([]);

return;

}

- if (!this._suggestBox)

+ if (!this._suggestBox) {

this._suggestBox = new UI.SuggestBox(this, 20, this._config.captureEnter);

+ this._suggestBox.setUserInteractionStyling(!!this._config.captureEnter);

dgozman 2017/03/11 00:00:24 setDefaultSelectionIsDimmed

lushnikov 2017/03/11 00:09:59 Done.

+ }

var oldQueryRange = this._queryRange;

this._queryRange = queryRange;