Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2714)

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.h

Issue 2742473002: gpu benchmarking swipe for touchpad
Patch Set: swipe direction fixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/gpu_benchmarking_extension.h
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.h b/content/renderer/gpu/gpu_benchmarking_extension.h
index 2b69d2b1329b1bb60d2669771ee08bf5498d25a4..d9bd41e59a5961f6d80a12e76a2fa33a61619ea7 100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.h
+++ b/content/renderer/gpu/gpu_benchmarking_extension.h
@@ -48,7 +48,14 @@ class GpuBenchmarking : public gin::Wrappable<GpuBenchmarking> {
bool GestureSourceTypeSupported(int gesture_source_type);
bool SmoothScrollBy(gin::Arguments* args);
bool SmoothDrag(gin::Arguments* args);
+
+ // This function generates a scroll followed by a fling. The default input
+ // source is touch; Source, velocity_x, and velocity_y are extra args that
+ // are necessary for a touchpad fling. Note that the callback function of
+ // swipe will get called only when the GFS is handled by the compositor
+ // thread.
tdresser 2017/03/21 19:20:02 Why will the callback only be called when the GFS
sahel 2017/03/22 14:43:25 I traced back the messages. When the compositor ha
tdresser 2017/03/22 15:21:29 Yikes. Can you file a bug for this? Maybe assign i
sahel 2017/03/22 16:04:04 Done.
bool Swipe(gin::Arguments* args);
+
bool ScrollBounce(gin::Arguments* args);
bool PinchBy(gin::Arguments* args);
bool Tap(gin::Arguments* args);

Powered by Google App Engine
This is Rietveld 408576698