chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java - Issue 2742433002: 📰 Do not refresh Tiles while visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java

Issue 2742433002: 📰 Do not refresh Tiles while visible (Closed)

Patch Set: move loadTiles with other private methods Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java

index c84d09a0fd1e48cbe325b73c5b897f3815facccf..1bf6755621b4903482135918dc862467826676b5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java

@@ -440,6 +440,11 @@ public Tab getActiveTab() {

return mTabModelSelector.getCurrentTab();

}

+ @Override

+ public boolean isVisible() {

+ return mCurrentState != SHEET_STATE_PEEK;

+ }

/**

* Determines if a touch event is inside the toolbar. This assumes the toolbar is the full

* width of the screen and that the toolbar is at the top of the bottom sheet.