Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2742333007: Add Observatory support for UnlinkedCall, SingleTargetCache and SubtypeTestCache. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Observatory support for UnlinkedCall, SingleTargetCache and SubtypeTestCache. Apply dartfmt to the touched files. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8d6aca7085c13f10a57b73cef7b5575f28abdec3

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1076 lines, -73 lines) Patch
M runtime/observatory/lib/elements.dart View 1 12 chunks +51 lines, -33 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 4 chunks +9 lines, -3 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 3 chunks +54 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 2 chunks +11 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/elements/singletargetcache_ref.dart View 1 chunk +67 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/singletargetcache_view.dart View 1 chunk +185 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/subtypetestcache_ref.dart View 1 chunk +65 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/subtypetestcache_view.dart View 1 chunk +159 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/unlinkedcall_ref.dart View 1 1 chunk +63 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/unlinkedcall_view.dart View 1 1 chunk +171 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/single_target_cache.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/subtype_test_cache.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/unlinked_call.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/single_target_cache.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/subtype_test_cache.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/unlinked_call.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/single_target_cache.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/subtype_test_cache.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/unlinked_call.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 13 chunks +92 lines, -27 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 4 chunks +15 lines, -0 lines 0 comments Download
M runtime/vm/object_service.cc View 2 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
3 years, 9 months ago (2017-03-15 23:06:04 UTC) #3
Cutch
lgtm
3 years, 9 months ago (2017-03-16 17:18:37 UTC) #4
rmacnak
3 years, 9 months ago (2017-03-16 19:34:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8d6aca7085c13f10a57b73cef7b5575f28abdec3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698