Move some of analyzer's code generation utilities into front_end.

Move some of analyzer's code generation utilities into front_end.

These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.

Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/c78b4d66bb3e0440fdd3020b45f3d00d78082525

[Paul Berry, 2017-03-14 17:46:01]

Description was changed from

==========
Move some of analyzer's code generation utilities into front_end.

These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.
==========

to

==========
Move some of analyzer's code generation utilities into front_end.

These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.

Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.
==========

[Paul Berry, 2017-03-14 17:46:11]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-03-14 18:00:51]

It might be cleaner for the tools.dart in analyzer to export the tools.dart in
front_end rather than to change so many imports, but you might have a reason for
not doing that.

In either case, lgtm.

[Paul Berry, 2017-03-14 19:26:09]

On 2017/03/14 18:00:51, Brian Wilkerson wrote:
> It might be cleaner for the tools.dart in analyzer to export the tools.dart in
> front_end rather than to change so many imports, but you might have a reason
for
> not doing that.
> 
> In either case, lgtm.

Yeah, it's a bigger diff this way, but I like avoiding the extra indirection
when possible.

(Of course, if any of these tools were being exported through analyzer's public
API, an extra indirection through an "export" declaration would be unavoidable).

[Paul Berry, 2017-03-14 19:30:24]

Description was changed from

==========
Move some of analyzer's code generation utilities into front_end.

These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.

Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.
==========

to

==========
Move some of analyzer's code generation utilities into front_end.

These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.

Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c78b4d66bb3e0440fdd3020b45f3d00d78082525
==========

[Paul Berry, 2017-03-14 19:30:25]

Committed patchset #1 (id:1) manually as
c78b4d66bb3e0440fdd3020b45f3d00d78082525 (presubmit successful).