Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml

Issue 2742293006: Support event handling in SVG's use-element shadow trees (Closed)
Patch Set: needs rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml
diff --git a/third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml b/third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml
index 695afaeff24819b39ace3e84ee9b83430e5c188e..c7cf254674d04aaf26ad09c4b24470cc31817312 100644
--- a/third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml
+++ b/third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml
@@ -19,11 +19,10 @@ if (window.testRunner) {
testRunner.waitUntilDone();
}
-function eventHandler(event)
+function eventHandler()
{
var divElement = document.getElementById("console");
- if (event.target == document.getElementById("test"))
- divElement.textContent = "Test passed";
+ divElement.textContent = "Test passed";
if (window.testRunner)
testRunner.notifyDone();
@@ -43,9 +42,8 @@ function startTest() {
// No-op, as no listener is not yet registered
fireSimulatedMouseClickEvent(shadowRoot.firstChild);
- // Add listeners
+ // Add listener
shadowRoot.firstChild.addEventListener("click", eventHandler, false);
- useElement.addEventListener("click", eventHandler, false);
// Should fire immediately and finish the test
fireSimulatedMouseClickEvent(shadowRoot.firstChild);

Powered by Google App Engine
This is Rietveld 408576698