Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc

Issue 2742293004: Expose getters methods for NQE on UI thread (Closed)
Patch Set: ps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
diff --git a/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc b/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
index e4119d5ddfb43bbb79e2e5c5130acfb467b6caea..7c1c9a430e092bcc72d500ddda776382d50b9acf 100644
--- a/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
+++ b/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
@@ -257,11 +257,25 @@ IN_PROC_BROWSER_TEST_F(UINetworkQualityEstimatorServiceBrowserTest,
nqe_test_util::OverrideRTTsAndWait(rtt_1);
EXPECT_EQ(rtt_1, nqe_observer.http_rtt());
+ base::TimeDelta got_rtt;
+ int32_t got_kbps;
+ EXPECT_TRUE(nqe_service->GetHttpRTT(&got_rtt));
+ EXPECT_EQ(rtt_1, got_rtt);
+ EXPECT_TRUE(nqe_service->GetTransportRTT(&got_rtt));
+ EXPECT_EQ(rtt_1, got_rtt);
+ EXPECT_FALSE(nqe_service->GetDownlinkThroughputKbps(&got_kbps));
+
base::TimeDelta rtt_2 = base::TimeDelta::FromMilliseconds(200);
nqe_test_util::OverrideRTTsAndWait(rtt_2);
EXPECT_EQ(rtt_2, nqe_observer.http_rtt());
+ EXPECT_TRUE(nqe_service->GetHttpRTT(&got_rtt));
+ EXPECT_EQ(rtt_2, got_rtt);
+ EXPECT_TRUE(nqe_service->GetTransportRTT(&got_rtt));
+ EXPECT_EQ(rtt_2, got_rtt);
+ EXPECT_FALSE(nqe_service->GetDownlinkThroughputKbps(&got_kbps));
+
nqe_service->RemoveRTTAndThroughputEstimatesObserver(&nqe_observer);
base::TimeDelta rtt_3 = base::TimeDelta::FromMilliseconds(300);
@@ -269,6 +283,12 @@ IN_PROC_BROWSER_TEST_F(UINetworkQualityEstimatorServiceBrowserTest,
nqe_test_util::OverrideRTTsAndWait(rtt_3);
EXPECT_EQ(rtt_2, nqe_observer.http_rtt());
+ EXPECT_TRUE(nqe_service->GetHttpRTT(&got_rtt));
+ EXPECT_EQ(rtt_3, got_rtt);
+ EXPECT_TRUE(nqe_service->GetTransportRTT(&got_rtt));
+ EXPECT_EQ(rtt_3, got_rtt);
+ EXPECT_FALSE(nqe_service->GetDownlinkThroughputKbps(&got_kbps));
+
// Observer should be notified on addition.
TestRTTAndThroughputEstimatesObserver nqe_observer_2;
nqe_service->AddRTTAndThroughputEstimatesObserver(&nqe_observer_2);

Powered by Google App Engine
This is Rietveld 408576698