Chromium Code Reviews| Index: tools/perf/benchmarks/webrtc.py |
| diff --git a/tools/perf/benchmarks/webrtc.py b/tools/perf/benchmarks/webrtc.py |
| index d9388a7fc052b8310042dc0b517bd7ad7bbd3412..8b1bea3afc14b47b1c629a2dc82c23f834ac2783 100644 |
| --- a/tools/perf/benchmarks/webrtc.py |
| +++ b/tools/perf/benchmarks/webrtc.py |
| @@ -91,3 +91,30 @@ class WebrtcRendering(perf_benchmark.PerfBenchmark): |
| @classmethod |
| def Name(cls): |
| return 'webrtc.webrtc_smoothness' |
| + |
| + |
| +# WebrtcRenderingTBMv2 must be a PerfBenchmark, and not a _Webrtc, because it is |
| +# a timeline-based metric. |
| +class WebrtcRenderingTBMv2(perf_benchmark.PerfBenchmark): |
|
nednguyen
2017/03/15 13:26:38
can you add @benchmark.Owner(emails=...) for this
|
| + """Specific time measurements (e.g. fps, smoothness) for WebRtc rendering.""" |
| + |
| + page_set = page_sets.WebrtcRenderingPageSet |
| + |
| + def CreateTimelineBasedMeasurementOptions(self): |
| + category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter( |
| + filter_string='webrtc,webkit.console,toplevel') |
|
nednguyen
2017/03/15 13:26:38
you don't need webkit.console category.
|
| + options = timeline_based_measurement.Options(category_filter) |
| + options.SetTimelineBasedMetrics([ |
| + 'cpuTimeMetric', |
| + 'expectedQueueingTimeMetric', |
|
ehmaldonado_chromium
2017/03/14 19:54:00
Because of crbug.com/671121
|
| + 'webrtcRenderingMetric', |
| + ]) |
| + return options |
| + |
| + def SetExtraBrowserOptions(self, options): |
| + options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') |
| + options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') |
| + |
| + @classmethod |
| + def Name(cls): |
| + return 'webrtc.webrtc_smoothness_tbmv2' |