Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2742283003: Fix for parsing named constructors with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-03-13 17:44:57 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-13 17:46:57 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 2a0bd99f8f4c170fd211e43426a987beb57e214c (presubmit successful).
3 years, 9 months ago (2017-03-13 17:50:11 UTC) #4
ahe
3 years, 9 months ago (2017-03-14 13:19:54 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698