Removed use of CRWSessionController from NativeAppNavigationUtilsTest.

ios/web/public/test/fakes/test_navigation_manager.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/public/test/fakes/test_navigation_manager.h"
 
 namespace web {
 
 TestNavigationManager::TestNavigationManager()
-    : pending_item_(nullptr),
+    : items_count_(-1),
+      pending_item_(nullptr),
       last_committed_item_(nullptr),
       visible_item_(nullptr) {}
 
 TestNavigationManager::~TestNavigationManager() {}
 
 BrowserState* TestNavigationManager::GetBrowserState() const {
   NOTREACHED();
   return nullptr;
 }
 
@@ skipping 43 matching lines @@
     const NavigationManager::WebLoadParams& params) {
   NOTREACHED();
 }
 
 void TestNavigationManager::AddTransientURLRewriter(
     BrowserURLRewriter::URLRewriter rewriter) {
   NOTREACHED();
 }
 
 int TestNavigationManager::GetItemCount() const {
-  NOTREACHED();
-  return 0;
+  return items_.size();
 }
 
 web::NavigationItem* TestNavigationManager::GetItemAtIndex(size_t index) const {
-  NOTREACHED();
-  return nullptr;
+  return items_[index].get();
 }
 
 int TestNavigationManager::GetCurrentItemIndex() const {
-  NOTREACHED();
-  return 0;
+  return items_count_;
+}
+
+void TestNavigationManager::SetCurrentItemIndex(const int index) {
+  DCHECK(index == -1 || index >= 0 && index < GetItemCount());
+  items_count_ = index;
 }
 
 int TestNavigationManager::GetLastCommittedItemIndex() const {
   NOTREACHED();
   return 0;
 }
 
 int TestNavigationManager::GetPendingItemIndex() const {
   NOTREACHED();
   return 0;
 }
 
 bool TestNavigationManager::RemoveItemAtIndex(int index) {
-  NOTREACHED();
-  return false;
+  if (index < 0 || index >= GetItemCount())
+    return false;
+  items_.erase(items_.begin() + index);
+  SetCurrentItemIndex(GetItemCount() - 1);

[Eugene But (OOO till 7-30), 2017/03/14 16:52:11]

This is quite unexpected side effect. SessionController does this instead:

if (_currentNavigationIndex > index)
  _currentNavigationIndex--;

[pkl (ping after 24h if needed), 2017/03/14 21:16:19]

Thanks for pointing this out. To mimic what's currently in SessionController,
I've added a DCHECK for index cannot be the current index.

+  return true;
 }
 
 bool TestNavigationManager::CanGoBack() const {
   NOTREACHED();
   return false;
 }
 
 bool TestNavigationManager::CanGoForward() const {
   NOTREACHED();
   return false;
@@ skipping 18 matching lines @@
 
 void TestNavigationManager::Reload(ReloadType reload_type,
                                    bool check_for_repost) {
   NOTREACHED();
 }
 
 void TestNavigationManager::OverrideDesktopUserAgentForNextPendingItem() {
   NOTREACHED();
 }
 
+// Adds a new navigation item of |transition| type at the end of this
+// navigation manager.
+void TestNavigationManager::AddItem(const std::string& url_spec,
+                                    ui::PageTransition transition) {
+  items_.push_back(web::NavigationItem::Create());
+  items_.back()->SetTransitionType(transition);
+  items_.back()->SetURL(GURL(url_spec));
+  SetCurrentItemIndex(GetItemCount() - 1);
+}
+
 }  // namespace web