Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: tracing/tracing/value/ui/histogram_set_table_test.html

Issue 2742163002: Generalize delta statistics in Histogram. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/histogram_set_table_row.html ('k') | tracing/tracing/value/ui/histogram_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/histogram_set_table_test.html
diff --git a/tracing/tracing/value/ui/histogram_set_table_test.html b/tracing/tracing/value/ui/histogram_set_table_test.html
index 6ae59262c984aadc447217d12cf71916dc79535e..5f3f129d04c4dd498457ea97a1585f3d12f9e135 100644
--- a/tracing/tracing/value/ui/histogram_set_table_test.html
+++ b/tracing/tracing/value/ui/histogram_set_table_test.html
@@ -445,11 +445,11 @@ tr.b.unittest.testSuite(function() {
barCell, elem => elem.id === 'content');
assert.isDefined(barContent);
- assert.strictEqual(table.displayStatistic, tr.v.ABS_DELTA_AVG_NAME);
+ assert.strictEqual(table.displayStatistic, `${tr.v.DELTA}avg`);
assert.strictEqual('20.000 ms', fooContent.textContent);
assert.strictEqual('-18.000 ms', barContent.textContent);
- table.displayStatistic = tr.v.PCT_DELTA_AVG_NAME;
+ table.displayStatistic = `%${tr.v.DELTA}avg`;
fooCell = tr.b.findDeepElementMatchingPredicate(table, elem => (
(elem.tagName === 'TR-V-UI-HISTOGRAM-SET-TABLE-CELL') &&
@@ -471,7 +471,7 @@ tr.b.unittest.testSuite(function() {
barCell, elem => elem.id === 'content');
assert.isDefined(barContent);
- assert.strictEqual(table.displayStatistic, tr.v.PCT_DELTA_AVG_NAME);
+ assert.strictEqual(table.displayStatistic, `%${tr.v.DELTA}avg`);
assert.strictEqual('20.000 ms', fooContent.textContent);
assert.strictEqual('-90.000%', barContent.textContent);
});
@@ -1040,7 +1040,7 @@ tr.b.unittest.testSuite(function() {
let nameCell = tr.b.findDeepElementMatchingPredicate(
table, e => e.tagName === 'TR-V-UI-HISTOGRAM-SET-TABLE-NAME-CELL');
- assert.strictEqual(321, nameCell.getBoundingClientRect().width);
+ assert.closeTo(321, nameCell.getBoundingClientRect().width, 1);
nameHeaderCell.children[1].click();
assert.isBelow(322, nameCell.getBoundingClientRect().width);
nameHeaderCell.children[1].click();
« no previous file with comments | « tracing/tracing/value/ui/histogram_set_table_row.html ('k') | tracing/tracing/value/ui/histogram_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698