Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: tracing/tracing/value/ui/histogram_set_table.html

Issue 2742163002: Generalize delta statistics in Histogram. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram_test.html ('k') | tracing/tracing/value/ui/histogram_set_table_cell.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/histogram_set_table.html
diff --git a/tracing/tracing/value/ui/histogram_set_table.html b/tracing/tracing/value/ui/histogram_set_table.html
index 86a990e9bb014860e12d54fd22f1d3be6cccf67b..4e8a37a58625d5d6048b654682ac84004d845fcb 100644
--- a/tracing/tracing/value/ui/histogram_set_table.html
+++ b/tracing/tracing/value/ui/histogram_set_table.html
@@ -397,9 +397,8 @@ tr.exportTo('tr.v.ui', function() {
this.setExpansionStates_(expansionStates);
this.updateStatisticSelector_();
- if (prevReferenceDisplayLabel === '' && this.referenceDisplayLabel &&
- this.displayStatistic === 'avg') {
- this.displayStatistic = tr.v.ABS_DELTA_AVG_NAME;
+ if (prevReferenceDisplayLabel === '' && this.referenceDisplayLabel) {
+ this.displayStatistic = tr.v.DELTA + this.displayStatistic;
}
},
@@ -419,7 +418,8 @@ tr.exportTo('tr.v.ui', function() {
Polymer.dom(this.$.statistic_container).textContent = '';
let statNames = Array.from(this.statNames);
if (this.referenceDisplayLabel) {
- statNames = statNames.concat(tr.v.DELTA_STATISTIC_NAMES);
+ statNames.push.apply(
+ statNames, tr.v.Histogram.getDeltaStatisticsNames(statNames));
}
if (statNames.indexOf(this.displayStatistic_) < 0) {
// createSelector throws if defaultValue is not in options.
« no previous file with comments | « tracing/tracing/value/histogram_test.html ('k') | tracing/tracing/value/ui/histogram_set_table_cell.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698