Issue 27421002: MIPS: Make TestJSArrayForAllocationMemento less awkward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27421002: MIPS: Make TestJSArrayForAllocationMemento less awkward. (Closed)

Created:
7 years, 2 months ago by palfia

Modified:
7 years, 2 months ago

Reviewers:
kisg, Paul Lind, mvstanton, kilvadyb, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Make TestJSArrayForAllocationMemento less awkward. Port r17220 (be968d52) Original commit message: Generated code ended up having two conditional jump statements in a row. Also introduce JumpIfJSArrayHasAllocationMemento which handles most cases more simply. BUG= R=gergely@homejinni.com Committed: https://code.google.com/p/v8/source/detail?r=17225

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -18 lines)			Patch
M	src/mips/codegen-mips.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

palfia

7 years, 2 months ago (2013-10-15 23:12:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17225 (presubmit successful).

Expand Messages | Collapse Messages