Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: content/browser/download/download_create_info.h

Issue 2742093002: Glue parallel download job and download file together. (Closed)
Patch Set: Work on feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_create_info.h
diff --git a/content/browser/download/download_create_info.h b/content/browser/download/download_create_info.h
index 174fded169ade9ae4f99c689987daa6c18aba238..ab724b9b90d50c3528a23b8146742686446eb91b 100644
--- a/content/browser/download/download_create_info.h
+++ b/content/browser/download/download_create_info.h
@@ -62,6 +62,9 @@ struct CONTENT_EXPORT DownloadCreateInfo {
// The total download size.
int64_t total_bytes;
asanka 2017/03/17 17:10:09 This is now the size of the response body, not the
xingliu 2017/03/17 19:08:25 Done, change the comment here, to address this is
+ // The starting position of the request to save to the target file.
asanka 2017/03/17 17:10:09 Can you add a comment indicating that this must ma
xingliu 2017/03/17 19:08:25 Done, also put a TODO, I think if we refactor job
+ int64_t offset;
+
// True if the download was initiated by user action.
bool has_user_gesture;
« no previous file with comments | « no previous file | content/browser/download/download_create_info.cc » ('j') | content/browser/download/download_file_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698