Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/download/download_job_factory.cc

Issue 2742093002: Glue parallel download job and download file together. (Closed)
Patch Set: Work on feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_job_factory.cc
diff --git a/content/browser/download/download_job_factory.cc b/content/browser/download/download_job_factory.cc
index 3d292c96cc4663e9c1a239ef4caecd702cfd13a0..a619b04e66559165d5bcc0f6d202fe10db66d151 100644
--- a/content/browser/download/download_job_factory.cc
+++ b/content/browser/download/download_job_factory.cc
@@ -16,28 +16,6 @@
namespace content {
-namespace {
-
-bool ShouldUseParallelDownload(const DownloadCreateInfo& create_info) {
- // 1. Accept-Ranges, Content-Length and strong validators response headers.
- // 2. Feature |kParallelDownloading| enabled.
- // 3. Content-Length is no less than the minimum slice size configuration.
- // 3. (Undetermined) Http/1.1 protocol.
- // 4. (Undetermined) Not under http proxy, e.g. data saver.
-
- // Etag and last modified are stored into DownloadCreateInfo in
- // DownloadRequestCore only if the response header complies to the strong
- // validator rule.
- bool has_strong_validator =
- !create_info.etag.empty() || !create_info.last_modified.empty();
-
- return has_strong_validator && create_info.accept_range &&
- create_info.total_bytes >= GetMinSliceSizeConfig() &&
- base::FeatureList::IsEnabled(features::kParallelDownloading);
-}
-
-} // namespace
-
std::unique_ptr<DownloadJob> DownloadJobFactory::CreateJob(
DownloadItemImpl* download_item,
std::unique_ptr<DownloadRequestHandleInterface> req_handle,

Powered by Google App Engine
This is Rietveld 408576698