Glue parallel download job and download file together.

content/browser/download/download_file_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
 #include <vector>
 
@@ skipping 21 matching lines @@
 #include "net/base/net_errors.h"
 #include "net/log/net_log_with_source.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::AnyNumber;
 using ::testing::DoAll;
 using ::testing::InSequence;
 using ::testing::Return;
+using ::testing::Sequence;
 using ::testing::SetArgPointee;
 using ::testing::StrictMock;
 
 namespace content {
 namespace {
 
 // Struct for SourceStream states verification.
 struct SourceStreamTestData {
   SourceStreamTestData(int64_t offset, int64_t bytes_written, bool finished)
       : offset(offset), bytes_written(bytes_written), finished(finished) {}
   int64_t offset;
   int64_t bytes_written;
   bool finished;
 };
 
+int64_t GetBuffersLength(const char** buffers, size_t num_buffer) {
+  int64_t result = 0;
+  for (size_t i = 0; i < num_buffer; ++i)
+    result += static_cast<int64_t>(strlen(buffers[i]));
+  return result;
+}
+
 std::string GetHexEncodedHashValue(crypto::SecureHash* hash_state) {
   if (!hash_state)
     return std::string();
   std::vector<char> hash_value(hash_state->GetHashLength());
   hash_state->Finish(&hash_value.front(), hash_value.size());
   return base::HexEncode(&hash_value.front(), hash_value.size());
 }
 
 class MockByteStreamReader : public ByteStreamReader {
  public:
@@ skipping 76 matching lines @@
 
 }  // namespace
 
 class DownloadFileTest : public testing::Test {
  public:
   static const char kTestData1[];
   static const char kTestData2[];
   static const char kTestData3[];
   static const char kTestData4[];
   static const char kTestData5[];
+  static const char* kTestData6[];
+  static const char* kTestData7[];
   static const char kDataHash[];
   static const char kEmptyHash[];
   static const uint32_t kDummyDownloadId;
   static const int kDummyChildId;
   static const int kDummyRequestId;
 
   DownloadFileTest()
       : observer_(new StrictMock<MockDownloadDestinationObserver>),
         observer_factory_(observer_.get()),
         input_stream_(NULL),
@@ skipping 27 matching lines @@
 
   void SetInterruptReasonCallback(const base::Closure& closure,
                                   DownloadInterruptReason* reason_p,
                                   DownloadInterruptReason reason) {
     *reason_p = reason;
     closure.Run();
   }
 
   bool CreateDownloadFile(int offset,
                           bool calculate_hash,
-                          bool is_sparse_file = false) {
+                          bool is_sparse_file = false,
+                          const DownloadItem::ReceivedSlices& received_slices =
+                              DownloadItem::ReceivedSlices()) {
     // There can be only one.
     DCHECK(!download_file_.get());
 
     input_stream_ = new StrictMock<MockByteStreamReader>();
 
     // TODO: Need to actually create a function that'll set the variables
     // based on the inputs from the callback.
     EXPECT_CALL(*input_stream_, RegisterCallback(_))
         .WillOnce(Invoke(this, &DownloadFileTest::RegisterCallback))
         .RetiresOnSaturation();
 
     std::unique_ptr<DownloadSaveInfo> save_info(new DownloadSaveInfo());
     download_file_.reset(new TestDownloadFileImpl(
         std::move(save_info), base::FilePath(),
-        std::unique_ptr<ByteStreamReader>(input_stream_),
-        std::vector<DownloadItem::ReceivedSlice>(),
+        std::unique_ptr<ByteStreamReader>(input_stream_), received_slices,
         net::NetLogWithSource(), is_sparse_file,
         observer_factory_.GetWeakPtr()));
 
     EXPECT_CALL(*input_stream_, Read(_, _))
         .WillOnce(Return(ByteStreamReader::STREAM_EMPTY))
         .RetiresOnSaturation();
 
     base::WeakPtrFactory<DownloadFileTest> weak_ptr_factory(this);
     DownloadInterruptReason result = DOWNLOAD_INTERRUPT_REASON_NONE;
     base::RunLoop loop_runner;
@@ skipping 161 matching lines @@
         base::Bind(&DownloadFileTest::SetRenameResult,
                    base::Unretained(this),
                    loop_runner.QuitClosure(),
                    &result_reason,
                    result_path_p);
     InvokeRenameMethod(method, full_path, completion_callback);
     loop_runner.Run();
     return result_reason;
   }
 
-  // Prepare two byte streams to write to the same file sink.
-  void PrepareMultipleStreams(int64_t second_stream_length) {
-    // Create a sparse file.
-    ASSERT_TRUE(CreateDownloadFile(0, true, true));
-    base::FilePath initial_path(download_file_->FullPath());
-    EXPECT_TRUE(base::PathExists(initial_path));
-    DCHECK(download_file_);
-
-    const char* stream_0_data[] = {kTestData1, kTestData2};
-    const char* stream_1_data[] = {kTestData4, kTestData5};
-    size_t stream_1_offset = strlen(kTestData1) + strlen(kTestData2);
-
-    // Register second SourceStream entry for the second stream.
-    // The first stream should be registered in ctor of DownloadFile.
-    DownloadFileImpl::SourceStreams& source_streams =
-        download_file_->source_streams_;
-    EXPECT_EQ(static_cast<size_t>(1), source_streams.size());
-    source_streams[stream_1_offset] =
-        base::MakeUnique<DownloadFileImpl::SourceStream>(stream_1_offset,
-                                                         second_stream_length);
-
-    // Create the second byte stream. Will be moved to DownloadFile.
-    input_stream_1_ = new MockByteStreamReader();
-
-    ::testing::Sequence s0;
-    ::testing::Sequence s1;
-    SetupDataAppend(stream_1_data, 2, input_stream_1_, s1, stream_1_offset);
-    SetupDataAppend(stream_0_data, 2, input_stream_, s0, 0);
-    SetupFinishStream(DOWNLOAD_INTERRUPT_REASON_NONE, input_stream_, s0);
+  // Prepare a byte stream to write to the file sink.
+  void PrepareStream(StrictMock<MockByteStreamReader>** stream,
+                     int64_t offset,
+                     bool create_stream,
+                     bool will_finish,
+                     const char** buffers,
+                     size_t num_buffer) {
+    if (create_stream)
+      *stream = new StrictMock<MockByteStreamReader>();
 
     // Expectation on MockByteStreamReader for MultipleStreams tests:
     // 1. RegisterCallback: Must called twice. One to set the callback, the
     // other to release the stream.
     // 2. Read: If filled with N buffer, called (N+1) times, where the last Read
     // call doesn't read any data but returns STRAM_COMPLETE.
     // The stream may terminate in the middle and less Read calls are expected.
     // 3. GetStatus: Only called if the stream is completed and last Read call
     // returns STREAM_COMPLETE.
-    if (second_stream_length == 0)
-      SetupFinishStream(DOWNLOAD_INTERRUPT_REASON_NONE, input_stream_1_, s1);
-    else
-      EXPECT_CALL(*input_stream_1_, RegisterCallback(_)).RetiresOnSaturation();
-
-    EXPECT_CALL(*input_stream_1_, RegisterCallback(_)).RetiresOnSaturation();
+    Sequence seq;
+    SetupDataAppend(buffers, num_buffer, *stream, seq, offset);
+    if (will_finish)
+      SetupFinishStream(DOWNLOAD_INTERRUPT_REASON_NONE, *stream, seq);
   }
 
   void VerifySourceStreamsStates(const SourceStreamTestData& data) {
     DCHECK(download_file_->source_streams_.find(data.offset) !=
            download_file_->source_streams_.end());
     DownloadFileImpl::SourceStream* stream =
         download_file_->source_streams_[data.offset].get();
     DCHECK(stream);
     EXPECT_EQ(data.offset, stream->offset());
     EXPECT_EQ(data.bytes_written, stream->bytes_written());
     EXPECT_EQ(data.finished, stream->is_finished());
   }
 
   int64_t TotalBytesReceived() const {
     DCHECK(download_file_);
     return download_file_->TotalBytesReceived();
   }
 
   std::unique_ptr<StrictMock<MockDownloadDestinationObserver>> observer_;
   base::WeakPtrFactory<DownloadDestinationObserver> observer_factory_;
 
   // DownloadFile instance we are testing.
   std::unique_ptr<DownloadFileImpl> download_file_;
 
   // Stream for sending data into the download file.
   // Owned by download_file_; will be alive for lifetime of download_file_.
   StrictMock<MockByteStreamReader>* input_stream_;
 
   // A second byte stream to test multiple stream write.
-  MockByteStreamReader* input_stream_1_;
+  StrictMock<MockByteStreamReader>* input_stream_1_;
 
   // Sink callback data for stream.
   base::Closure sink_callback_;
 
   // Latest update sent to the observer.
   int64_t bytes_;
   int64_t bytes_per_sec_;
 
  private:
   void SetRenameResult(const base::Closure& closure,
@@ skipping 40 matching lines @@
                         DownloadFileTestWithRename,
                         ::testing::Values(RENAME_AND_ANNOTATE,
                                           RENAME_AND_UNIQUIFY));
 
 const char DownloadFileTest::kTestData1[] =
     "Let's write some data to the file!\n";
 const char DownloadFileTest::kTestData2[] = "Writing more data.\n";
 const char DownloadFileTest::kTestData3[] = "Final line.";
 const char DownloadFileTest::kTestData4[] = "abcdefg";
 const char DownloadFileTest::kTestData5[] = "01234";
+const char* DownloadFileTest::kTestData6[] = {kTestData1, kTestData2};
+const char* DownloadFileTest::kTestData7[] = {kTestData4, kTestData5};
+
 const char DownloadFileTest::kDataHash[] =
     "CBF68BF10F8003DB86B31343AFAC8C7175BD03FB5FC905650F8C80AF087443A8";
 const char DownloadFileTest::kEmptyHash[] =
     "E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855";
 
 const uint32_t DownloadFileTest::kDummyDownloadId = 23;
 const int DownloadFileTest::kDummyChildId = 3;
 const int DownloadFileTest::kDummyRequestId = 67;
 
 // Rename the file before any data is downloaded, after some has, after it all
@@ skipping 354 matching lines @@
   sink_callback_.Run();
   base::RunLoop().RunUntilIdle();
   VerifyStreamAndSize();
   DestroyDownloadFile(0);
 }
 
 // Tests for concurrent streams handling, used for parallel download.
 //
 // Activate both streams at the same time.
 TEST_F(DownloadFileTest, MutipleStreamsWrite) {
-  PrepareMultipleStreams(0);
+  ASSERT_TRUE(CreateDownloadFile(0, true, true));
+  int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
+  int64_t stream_1_length = GetBuffersLength(kTestData7, 2);
+
+  PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
+  PrepareStream(&input_stream_1_, stream_0_length, true, true, kTestData7, 2);
+  DCHECK(input_stream_1_);

[asanka, 2017/03/14 19:44:01]

DCHECK isn't necessary since the code will reliably crash if it's nullptr.

[xingliu, 2017/03/14 22:48:29]

Done.

+
+  EXPECT_CALL(*input_stream_1_, RegisterCallback(_)).RetiresOnSaturation();
   EXPECT_CALL(*(observer_.get()), MockDestinationCompleted(_, _));
 
-  int64_t stream_0_length =
-      static_cast<int64_t>(strlen(kTestData1) + strlen(kTestData2));
-  int64_t stream_1_length =
-      static_cast<int64_t>(strlen(kTestData4) + strlen(kTestData5));
+  download_file_->AddByteStream(
+      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length,
+      0);
 
-  download_file_->AddByteStream(
-      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length);
+  // Activate the streams.
   sink_callback_.Run();
   base::RunLoop().RunUntilIdle();
 
   SourceStreamTestData stream_data_0(0, stream_0_length, true);
   SourceStreamTestData stream_data_1(stream_0_length, stream_1_length, true);
   VerifySourceStreamsStates(stream_data_0);
   VerifySourceStreamsStates(stream_data_1);
   EXPECT_EQ(stream_0_length + stream_1_length, TotalBytesReceived());
 
   DestroyDownloadFile(0);
 }
 
 // Activate and deplete one stream, later add the second stream.
-TEST_F(DownloadFileTest, MutipleStreamsOneStreamFirst) {
-  PrepareMultipleStreams(0);
+//
+// Disabled because we are changing the download file completion logic.
+// The first stream will make the download file complete after it finished.
+TEST_F(DownloadFileTest, DISABLED_MutipleStreamsOneStreamFirst) {
+  ASSERT_TRUE(CreateDownloadFile(0, true, true));
+  int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
+  int64_t stream_1_length = GetBuffersLength(kTestData7, 2);
 
-  int64_t stream_0_length =
-      static_cast<int64_t>(strlen(kTestData1) + strlen(kTestData2));
-  int64_t stream_1_length =
-      static_cast<int64_t>(strlen(kTestData4) + strlen(kTestData5));
-
-  // Deplete the first stream.
+  // Setup and deplete the first stream.
+  PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
   sink_callback_.Run();
   base::RunLoop().RunUntilIdle();
-
   SourceStreamTestData stream_data_0(0, stream_0_length, true);
-  SourceStreamTestData stream_data_1(stream_0_length, 0, false);
   VerifySourceStreamsStates(stream_data_0);
-  VerifySourceStreamsStates(stream_data_1);
   EXPECT_EQ(stream_0_length, TotalBytesReceived());
 
+  // Setup and activate the second stream.
+  PrepareStream(&input_stream_1_, stream_0_length, true, true, kTestData7, 2);
+  DCHECK(input_stream_1_);
+
+  EXPECT_CALL(*input_stream_1_, RegisterCallback(_)).RetiresOnSaturation();
   // Won't inform the observer until the second stream is depleted.
   EXPECT_CALL(*(observer_.get()), MockDestinationCompleted(_, _));
-
-  // Drain the second stream after the first stream is depleted.
   download_file_->AddByteStream(
-      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length);
+      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length,
+      0);
   base::RunLoop().RunUntilIdle();
 
-  stream_data_1.bytes_written = stream_1_length;
-  stream_data_1.finished = true;
+  SourceStreamTestData stream_data_1(stream_0_length, stream_1_length, true);
   VerifySourceStreamsStates(stream_data_0);
   VerifySourceStreamsStates(stream_data_1);
   EXPECT_EQ(stream_0_length + stream_1_length, TotalBytesReceived());
 
   DestroyDownloadFile(0);
 }
 
 // Two streams write to one sink, the second stream has a limited length.
 TEST_F(DownloadFileTest, MutipleStreamsLimitedLength) {
-  // The second stream has two buffers, kTestData4 and kTestData5.
-  // The length limit is set to less than the length of kTestData4.
-  // kTestData4 should be partially written to disk, where kTestData5 should be
-  // ignored.
-  int64_t stream_0_length =
-      static_cast<int64_t>(strlen(kTestData1) + strlen(kTestData2));
-  int64_t stream_1_length = static_cast<int64_t>(strlen(kTestData4)) - 1;
-  PrepareMultipleStreams(stream_1_length);
+  ASSERT_TRUE(CreateDownloadFile(0, true, true));
+  int64_t stream_0_length = GetBuffersLength(kTestData6, 2);
+  // The second stream has a limited length and should be partially written
+  // to disk.
+  int64_t stream_1_length = GetBuffersLength(kTestData7, 2) - 1;
 
+  PrepareStream(&input_stream_, 0, false, true, kTestData6, 2);
+  PrepareStream(&input_stream_1_, stream_0_length, true, false, kTestData7, 2);
+
+  EXPECT_CALL(*input_stream_1_, RegisterCallback(_))
+      .Times(2)
+      .RetiresOnSaturation();
   EXPECT_CALL(*(observer_.get()), MockDestinationCompleted(_, _));
 
+  // Activate both streams.
   download_file_->AddByteStream(
-      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length);
+      std::unique_ptr<MockByteStreamReader>(input_stream_1_), stream_0_length,
+      stream_1_length);
   sink_callback_.Run();
   base::RunLoop().RunUntilIdle();
 
   SourceStreamTestData stream_data_0(0, stream_0_length, true);
   SourceStreamTestData stream_data_1(stream_0_length, stream_1_length, true);
   VerifySourceStreamsStates(stream_data_0);
   VerifySourceStreamsStates(stream_data_1);
   EXPECT_EQ(stream_0_length + stream_1_length, TotalBytesReceived());
 
-  std::string disk_data, expected_data;
-  EXPECT_TRUE(base::ReadFileToString(download_file_->FullPath(), &disk_data));
-  expected_data.append(kTestData1).append(kTestData2).append(kTestData4);
-  expected_data = expected_data.substr(0, stream_0_length + stream_1_length);
-  EXPECT_EQ(expected_data, disk_data);
-
-  // Finish the second stream.
-  // TODO(xingliu): Refactor test code to deal with unfinished streams.
-  scoped_refptr<net::IOBuffer> data = new net::IOBuffer(strlen(kTestData5));
-  size_t size;
-  input_stream_1_->Read(&data, &size);
-
   DestroyDownloadFile(0, false);
 }
 
 }  // namespace content