Issue 27420005: [chromedriver] Don't catch exceptions raised during quit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27420005: [chromedriver] Don't catch exceptions raised during quit. (Closed)

Created:
7 years, 2 months ago by frankf

Modified:
7 years, 2 months ago

Reviewers:
kkania

CC:
chromium-reviews, craigdh

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/webdriver/

Visibility:
Public.

More Reviews

Description

[chromedriver] Don't catch exceptions raised during quit. It's better to terminate the entire test. Especially on Android, if quit doesn't succeed, subsequent tests will fail to create a session since the device is not freed. BUG=None R=kkania@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228958

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -14 lines)			Patch
M	patch.diff	View	3 chunks	+21 lines, -14 lines	0 comments	Download
M	test-nodeps-srcs.jar	View	Binary file		0 comments	Download
M	test-standalone.jar	View	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

frankf

7 years, 2 months ago (2013-10-16 18:40:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r228958 (presubmit successful).

Expand Messages | Collapse Messages