Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: runtime/vm/parser.cc

Issue 27420002: Throw a dynamic type error instead of a CastError in a type cast with a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 28684)
+++ runtime/vm/parser.cc (working copy)
@@ -7503,11 +7503,11 @@
// The type is never malformed (mapped to dynamic), but it can be
// malbounded in checked mode.
ASSERT(!type.IsMalformed());
- if (((op_kind == Token::kIS) || (op_kind == Token::kISNOT)) &&
+ if (((op_kind == Token::kIS) || (op_kind == Token::kISNOT) ||
+ (op_kind == Token::kAS)) &&
type.IsMalbounded()) {
// Note that a type error is thrown even if the tested value is null
- // in a type test. However, no cast exception is thrown if the value
- // is null in a type cast.
+ // in a type test or in a type cast.
return ThrowTypeError(type_pos, type);
}
}
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698