Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 274193008: Create a temp download directory for WebstorePrivateApiTest (Closed)

Created:
6 years, 7 months ago by asanka
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Create a temp download directory for WebstorePrivateApiTest This test was writing to the user's downloads directory instead of a temporary path. BUG=372017 R=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
asanka
One more :)
6 years, 7 months ago (2014-05-10 05:17:09 UTC) #1
asargent_no_longer_on_chrome
lgtm
6 years, 7 months ago (2014-05-10 05:27:48 UTC) #2
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 07:00:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/274193008/1
6 years, 7 months ago (2014-05-10 07:02:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 08:30:29 UTC) #5
asanka
The CQ bit was unchecked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 14:25:14 UTC) #6
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 14:25:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/274193008/1
6 years, 7 months ago (2014-05-10 14:26:41 UTC) #8
asanka
The CQ bit was unchecked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 14:50:58 UTC) #9
asanka
The CQ bit was checked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 14:52:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/274193008/1
6 years, 7 months ago (2014-05-10 14:53:20 UTC) #11
asanka
The CQ bit was unchecked by asanka@chromium.org
6 years, 7 months ago (2014-05-10 18:57:19 UTC) #12
asanka
6 years, 7 months ago (2014-05-10 18:58:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r269607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698