Issue 274193007: Back out r269483 and the line of fixes that followed it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274193007: Back out r269483 and the line of fixes that followed it. (Closed)

Created:
6 years, 7 months ago by Mark Mentovai

Modified:
6 years, 7 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Back out r269483 and the line of fixes that followed it. This backs out r296483, r269492, r269501, and r269511. The iOS bots hated it. They don't like mach_vm_* and must use vm_* instead, and they can't #include <mach/mach_vm.h> at all. The above patches dealt with that, but then when it turned out that the iOS bots also weren't even building ScopedMachVM or MACH_LOG at all, I decided to call it quits. http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/919/steps/compile/logs/stdio http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/921/steps/compile/logs/stdio http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16185/steps/compile/logs/stdio TBR=rsesek Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269516

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -183 lines)			Patch
M	base/mac/mac_logging.h	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	base/mac/mach_logging.h	View	6 chunks	+8 lines, -17 lines	0 comments	Download
M	base/mac/scoped_mach_port.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/mac/scoped_mach_vm.h	View	3 chunks	+2 lines, -20 lines	0 comments	Download
M	base/mac/scoped_mach_vm.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/memory/discardable_memory_mac.cc	View	3 chunks	+23 lines, -32 lines	0 comments	Download
M	base/process/memory_mac.mm	View	5 chunks	+6 lines, -9 lines	0 comments	Download
M	base/process/process_metrics_mac.cc	View	7 chunks	+42 lines, -27 lines	0 comments	Download
M	base/threading/platform_thread_mac.mm	View	6 chunks	+21 lines, -22 lines	0 comments	Download
M	base/time/time_mac.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/mac/install_from_dmg.mm	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/mach_broker_mac.mm	View	9 chunks	+38 lines, -32 lines	0 comments	Download

Total messages: 1 (0 generated)

Mark Mentovai

6 years, 7 months ago (2014-05-10 04:09:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r269516 (tree was closed).