Issue 274193004: Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274193004: Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (Closed)

Created:
6 years, 7 months ago by mef

Modified:
6 years, 7 months ago

Reviewers:
asanka

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. BUG=61827 NOTRY=true NOTREECHECKS=true R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269405

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	net/base/filename_util_internal.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/274193004/1

6 years, 7 months ago (2014-05-09 21:08:37 UTC) #3

asanka

6 years, 7 months ago (2014-05-19 17:17:58 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/292803002/ by asanka@chromium.org.

The reason for reverting is: This patch was landed speculatively due to the
suspicion that the removal of the ScopedAllowIO was to blame for
http://crbug.com/372017. The cause of that issue was found to lie elsewhere..

Expand Messages | Collapse Messages