third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp - Issue 2741923002: Add CHECKs in WindowProxy initialization/detach to enforce invariants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2741923002: Add CHECKs in WindowProxy initialization/detach to enforce invariants (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

index 040942b275d81a5d1febf9b9e6476134aba1069a..e496f5a8a3829ebe9a9c02aac9197afcb7a4f669 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

@@ -92,6 +92,7 @@ v8::Local<v8::Object> WindowProxy::releaseGlobal() {

}

void WindowProxy::setGlobal(v8::Local<v8::Object> global) {

+ CHECK(m_globalProxy.isEmpty());

m_globalProxy.set(m_isolate, global);

// Initialize the window proxy now, to re-establish the connection between

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp ('k') | no next file » | no next file with comments »