Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2741923002: Add CHECKs in WindowProxy initialization/detach to enforce invariants (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
index 47b58f7dd7629c8ca269082aa9d2e2c26d9e5b02..2d8c532682f416d052ef8c889707d48ca24a5388 100644
--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
@@ -82,12 +82,10 @@ void LocalWindowProxy::disposeContext(GlobalDetachmentBehavior behavior) {
v8::Local<v8::Context> context = m_scriptState->context();
// Clean up state on the global proxy, which will be reused.
if (!m_globalProxy.isEmpty()) {
- // TODO(yukishiino): This DCHECK failed on Canary (M57) and Dev (M56).
- // We need to figure out why m_globalProxy != context->Global().
- DCHECK(m_globalProxy == context->Global());
- DCHECK_EQ(toScriptWrappable(context->Global()),
- toScriptWrappable(
- context->Global()->GetPrototype().As<v8::Object>()));
+ CHECK(m_globalProxy == context->Global());
+ CHECK_EQ(toScriptWrappable(context->Global()),
+ toScriptWrappable(
+ context->Global()->GetPrototype().As<v8::Object>()));
m_globalProxy.get().SetWrapperClassId(0);
}
V8DOMWrapper::clearNativeInfo(isolate(), context->Global());
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698